Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes with aio-pika>9.1.2 #4513

Closed
1 task done
pcrespov opened this issue Jul 20, 2023 · 0 comments · Fixed by #4605
Closed
1 task done

Breaking changes with aio-pika>9.1.2 #4513

pcrespov opened this issue Jul 20, 2023 · 0 comments · Fixed by #4605
Assignees
Labels
t:maintenance Some planned maintenance work

Comments

@pcrespov
Copy link
Member

pcrespov commented Jul 20, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Planned changes

Need to review this test and determine whether this upgrade has an impact on the service aio-pika logic or is simply a bad test:

FAILED tests/rabbitmq/test_rabbitmq_rpc.py::test_replier_responds_with_not_locally_defined_object_instance - AttributeError: Can't pickle local object 'test_replier_responds_with_not_locally_defined_object_instance.<locals>._replier_scope.<locals>.Custom'

with aio-pika==9.1.3 and aio-pika==9.1.4

added aio-pika<9.1.3 in requirements/constraints.txt

NOTE: when fixed, do not forget to remove: aio-pika<9.1.3 in osparc-simcore/requirements/constraints.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants