Skip to content

Commit

Permalink
minors
Browse files Browse the repository at this point in the history
  • Loading branch information
odeimaiz committed Oct 15, 2024
1 parent 7c1cf01 commit 9d402dd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,8 @@ qx.Class.define("osparc.desktop.StudyEditor", {
case "DOWNLOAD_STARTED":
propsForm.retrievingPortData(
portId,
osparc.form.renderer.PropForm.RETRIEVE_STATUS.downloading);
osparc.form.renderer.PropForm.RETRIEVE_STATUS.downloading
);
break;
case "DOWNLOAD_FINISHED_SUCCESSFULLY":
propsForm.retrievedPortData(portId, true);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ qx.Class.define("osparc.form.renderer.PropForm", {
},

retrievingPortData: function(portId, status) {
if (!status) {
if (status === undefined) {
status = this.self().RETRIEVE_STATUS.retrieving;
}
if (portId) {
Expand Down Expand Up @@ -616,9 +616,6 @@ qx.Class.define("osparc.form.renderer.PropForm", {
},

__setRetrievingStatus: function(status, portId, idx, row) {
const icon = this.self().getIconForStatus(status);
icon.key = portId;

// remove first if any
let children = this._getChildren();
for (let i=0; i<children.length; i++) {
Expand All @@ -632,7 +629,8 @@ qx.Class.define("osparc.form.renderer.PropForm", {

const label = this._getLabelFieldChild(portId).child;
if (label && label.isVisible()) {
this._getLabelFieldChild(portId);
const icon = this.self().getIconForStatus(status);
icon.key = portId;
this._addAt(icon, idx, {
row,
column: this.self().GRID_POS.RETRIEVE_STATUS
Expand Down

0 comments on commit 9d402dd

Please sign in to comment.