Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Dont fail when cleaning up #222

Merged

Conversation

bisgaard-itis
Copy link
Collaborator

What do these changes do?

I have observed that our e2e tests sometimes fail when cleaning up, that's not intended

Related issue/s

How to test

For internal developers

@bisgaard-itis bisgaard-itis self-assigned this Nov 19, 2024
@bisgaard-itis bisgaard-itis added bug Something isn't working e2e labels Nov 19, 2024
@bisgaard-itis bisgaard-itis added this to the Event Horizon milestone Nov 19, 2024
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to add a logging.warning("some meaninful message", exc_info=True)

@bisgaard-itis bisgaard-itis merged commit 0388ebb into ITISFoundation:master Nov 19, 2024
1 check passed
@bisgaard-itis bisgaard-itis deleted the dont-fail-when-cleaning-up branch November 19, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants