Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e tests by not importing PaginationIterable #221

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix e2e tests by not importing PaginationIterable #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions clients/python/test/e2e/test_files_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
from pathlib import Path

import osparc
from osparc._utils import PaginationIterable
import pytest
from memory_profiler import memory_usage
from typing import Final, Callable
Expand Down Expand Up @@ -90,9 +89,7 @@ def test_search_files(
use_id: bool,
faker: Faker,
) -> None:
results: PaginationIterable = files_api._search_files(
sha256_checksum=f"{faker.sha256()}"
)
results = files_api._search_files(sha256_checksum=f"{faker.sha256()}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha ... tests are not backwareds compatible?!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. This is always the pain with these tests.

assert len(results) == 0, "Found file which shouldn't be there"

results = files_api._search_files(
Expand Down
Loading