Fixed issue where the detection was also running on the output folder triggering a chain update event #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 15, 2024 07:09
GitHK
changed the title
GitHK
requested review from
giancarloromeo,
pcrespov,
sanderegg,
matusdrobuliak66 and
bisgaard-itis
matusdrobuliak66
approved these changes
Nov 15, 2024
giancarloromeo
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Previous version was updating every second the outputs. Corrected the issue. Only updates when inputs change (which is how it should work).
Modified tests to detect this situation and only trigger once per change in inputs.
Related issue number
Checklist