Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove env EC2_INSTANCES_ALLOWED_TYPES from special handling #914

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove env EC2_INSTANCES_ALLOWED_TYPES from special handling #914

wants to merge 1 commit into from

Conversation

YuryHrytsuk
Copy link
Collaborator

What do these changes do?

  • Do no treat specially EC2_INSTANCES_ALLOWED_TYPES while baking .env for simcore services
  • As a result, $ signs are preserved as is in EC2_INSTANCES_ALLOWED_TYPES value

Related issue/s

Related PR/s

Checklist

  • I tested and it works

@YuryHrytsuk YuryHrytsuk added this to the Event Horizon milestone Dec 17, 2024
@YuryHrytsuk YuryHrytsuk self-assigned this Dec 17, 2024
mrnicegyu11
mrnicegyu11 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I guess you and SAN talked about this, is there a sister PR with changes in osparc-simcore or so that enables this, or does it work out of the box? thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

Assignees

@YuryHrytsuk YuryHrytsuk

Labels
p:mid-prio
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
3 participants
@YuryHrytsuk @mrnicegyu11 @sanderegg