Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sister PR for https://github.com/ITISFoundation/osparc-simcore/pull/6691 #872

Merged
merged 9 commits into from
Nov 13, 2024

Conversation

mrnicegyu11
Copy link
Member

What do these changes do?

Add interactive services network to opentelemetry provider in jaeger stack.

Related issue/s

Related PR/s

https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/1079
ITISFoundation/osparc-simcore#6691

Checklist

  • I tested and it works

@YuryHrytsuk
Copy link
Collaborator

The problem of this PR is that OTEL now will not run without interactive_services_subnet (read simcore).

The advantage if this approach is security (instead of having all services in common network, we put OTEL to each network)

@mrnicegyu11 mrnicegyu11 marked this pull request as ready for review November 13, 2024 12:55
@mrnicegyu11
Copy link
Member Author

Talked about it manually, resolved :--)

@mrnicegyu11 mrnicegyu11 merged commit 3a0e944 into ITISFoundation:main Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants