Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 Add: Make RUT replica configurable via envvar #864

Conversation

mrnicegyu11
Copy link
Member

@mrnicegyu11 mrnicegyu11 commented Nov 5, 2024

What do these changes do?

Related issue/s

Related PR/s

https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/1053

Checklist

  • I tested and it works

@mrnicegyu11 mrnicegyu11 self-assigned this Nov 5, 2024
@mrnicegyu11 mrnicegyu11 added this to the Event Horizon milestone Nov 5, 2024
@mrnicegyu11 mrnicegyu11 changed the title Add: make RUT replica configurable via envvar 💄 Add: Make RUT replica configurable via envvar Nov 5, 2024
@mrnicegyu11 mrnicegyu11 added t:enhancement New feature or request FAST labels Nov 5, 2024
@mrnicegyu11 mrnicegyu11 marked this pull request as ready for review November 5, 2024 13:25
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool and we setup in all deployments to 3 and in AWS master to 0 correct?

@YuryHrytsuk
Copy link
Collaborator

YuryHrytsuk commented Nov 6, 2024

Cool and we setup in all deployments to 3 and in AWS master to 0 correct?

  1. Why? Don't you use it for resource usage tracking?
  2. Since on AWS Master this is the only Simcore Service running on Kubernetes, I would keep it up.

@mrnicegyu11
Copy link
Member Author

Cool and we setup in all deployments to 3 and in AWS master to 0 correct?

1. Why? Don't you use it for resource usage tracking?

2. Since on AWS Master this is the only Simcore Services running on Kubernetes, I would keep it up.

@matusdrobuliak66 as code owner who specifically requested this please talk to @YuryHrytsuk directly, merci :--) I am flexible to put in whatever u guys decide on,

@YuryHrytsuk
Copy link
Collaborator

YuryHrytsuk commented Nov 6, 2024

Cool and we setup in all deployments to 3 and in AWS master to 0 correct?

1. Why? Don't you use it for resource usage tracking?

2. Since on AWS Master this is the only Simcore Services running on Kubernetes, I would keep it up.

@matusdrobuliak66 as code owner who specifically requested this please talk to @YuryHrytsuk directly, merci :--) I am flexible to put in whatever u guys decide on,

The decision is to introduce this new ENV controlling RUT's replicas in Docker Swarm [only!] and set it to 0 on AWS Master, so that we will run RUT only on Kubernetes. On all other deplyoments we can configure it as it was before

My confusion arose from my assumption that it will scale RUT to 0 on AWS Master's Kubernetes also but this is not the case.

@mrnicegyu11 mrnicegyu11 merged commit fa7d040 into ITISFoundation:main Nov 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FAST t:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants