Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stack-yaml-generated-is-valid pre-commit hook #858

Conversation

YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Oct 29, 2024

What do these changes do?

Remove stack-yaml-generated-is-valid pre-commit hook

Rationale
This hook relies on .config.location and on manually generated repo.config in osparc-config repository. This pre-commit hook will fail for any new user trying to commit to the osparc-ops-environments since these users are unaware of the dependency on repo.config from osparc-config repository. Moreover, any non-ITIS user cannot even get this repository (hence commit at all) since it is not publicly available.

UPD:
The idea of pre-commit hook relying on physical generated files from other repositories seems to be wrong. This is why in our GitHub CI we cannot run pre-commit as is (we have to skip stack-yaml-generated-is-valid hook)

Related issue/s

Related PR/s

Checklist

  • I tested and it works

@YuryHrytsuk YuryHrytsuk added this to the MartinKippenberger milestone Oct 29, 2024
@YuryHrytsuk YuryHrytsuk requested a review from sanderegg October 29, 2024 07:12
@YuryHrytsuk YuryHrytsuk self-assigned this Oct 29, 2024
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can agree with what you wrote, this test was useful some years ago when it still worked properly, but not anymore. Thanks!

@YuryHrytsuk YuryHrytsuk merged commit 170a2a4 into ITISFoundation:main Oct 29, 2024
3 checks passed
@YuryHrytsuk YuryHrytsuk deleted the remove-stack-yml-generated-is-valid-pre-commit branch October 29, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants