Remove stack-yaml-generated-is-valid
pre-commit hook
#858
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Remove
stack-yaml-generated-is-valid
pre-commit hookRationale
This hook relies on
.config.location
and on manually generatedrepo.config
inosparc-config
repository. This pre-commit hook will fail for any new user trying to commit to theosparc-ops-environments
since these users are unaware of the dependency onrepo.config
fromosparc-config
repository. Moreover, any non-ITIS user cannot even get this repository (hence commit at all) since it is not publicly available.UPD:
The idea of pre-commit hook relying on physical generated files from other repositories seems to be wrong. This is why in our GitHub CI we cannot run
pre-commit
as is (we have to skipstack-yaml-generated-is-valid
hook)Related issue/s
Related PR/s
Checklist