Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #6

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Update README.md #6

merged 1 commit into from
Oct 20, 2023

Conversation

elisabettai
Copy link
Collaborator

@elisabettai elisabettai commented Oct 19, 2023 •
edited
Loading

update readme to trigger a CI run and unblock the publisher CI on Gitlab.

For unblocking the publisher CI, it is OK that this CI is red. However, since it fails to build the image, we'll need at some point to publish a new version.

@elisabettai elisabettai requested review from GitHK and mguidon October 19, 2023 15:39
mguidon
mguidon approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand.

@elisabettai
Copy link
Collaborator Author

elisabettai commented Oct 19, 2023 •
edited
Loading

Not sure I understand.

@mguidon, we have a known issue. After a while, GitHub CIs "expire" and that makes our publisher CI fail (the one that monitors repositories and automatically publishes new versions of services to our registry).

@elisabettai
Copy link
Collaborator Author

elisabettai commented Oct 19, 2023 •
edited
Loading

And sorry to disturb @mguidon, your approval it's not sufficient (I've realized that only now). I need one from users with write access, e.g. @GitHK.

GitHK
GitHK approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. I see that there is a missing image on GitHub in the build.

@elisabettai elisabettai merged commit 4ccd73f into master Oct 20, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguidon mguidon mguidon approved these changes

@GitHK GitHK GitHK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elisabettai @GitHK @mguidon