Feature/optuna kube bench #26
Conversation
improved runner stability improved optuna_kube stability added tests for yaml serializations added integration tests for resouce_tracker removed sqlalchemy logging
| @@ -9,38 +9,6 @@ data: | |||
| POSTGRES_DB: postgresdb | |||
| POSTGRES_USER: postgresadmin | |||
| POSTGRES_PASSWORD: admin123 | |||
| # --- | |||
|
|
||
| def deploy(self) -> None: | ||
| """ | ||
| Deploy DB | ||
| """ | ||
| # TODO: deal with exsiting resources... | ||
|
|
||
| if self.hyperparameter: | ||
| #TODO: XXX we got to fix this dependency thing. eitehr merge minikube/kubernetes or use the same baseclass or something... |
There was a problem hiding this comment.
added as an issue in #22
| @@ -165,10 +206,11 @@ def undeploy(self): | |||
| if self.delete_after_run: | |||
| client.CoreV1Api().delete_namespace(self.namespace) | |||
| self._watch_namespace() | |||
| self.image_builder.cleanup(self.trial_tag) | |||
| # self.image_builder.cleanup(self.trial_tag) | |||
There was a problem hiding this comment.
image builder causes issues as images have to be forcefully deleted, at least in minikube added as an issue in #27
|
|
||
| def _watch_namespace(self): | ||
| try: | ||
| #TODO: XXX fix me! |
There was a problem hiding this comment.
while loop needed. Added as an Issue in #28
| @@ -0,0 +1,9 @@ | |||
| # generated file - do not edit | |||
There was a problem hiding this comment.
needs to be deleted after benchmark is finished. Adressed in #29
| from ml_benchmark.utils.yml_parser import YMLParser | ||
| import itertools | ||
|
|
||
| def generate_search_space(yaml_file_path): |
There was a problem hiding this comment.
hidden layer generation is not working. Issue #24
| print(e) | ||
| raise AttributeError("Functions need to be part of a class in order to measure their latency.") | ||
| self.add_to_id(f"function-name_{self.function_name}__objHash_{self.obj_hash}") | ||
| #TODO: make each id filed also availible as a column |
There was a problem hiding this comment.
I dont get that - what do you mean? Pls create issue if not already done
| yaml_path (str): filename to write yaml to | ||
| obj (any): object to save as yaml | ||
| """ | ||
| with open(yaml_path, "w") as f: |
There was a problem hiding this comment.
only one class to handle yaml. Adressed in #22
| @@ -50,7 +50,7 @@ def train(self): | |||
| epoch_losses.append(sum(batch_losses)/len(batch_losses)) | |||
| return {"train_loss": epoch_losses} | |||
|
|
|||
| @latency_decorator | |||
| @validation_latency_decorator | |||
There was a problem hiding this comment.
record dictionary in benchmrk metrics. Adressed in #21
| @@ -0,0 +1,16 @@ | |||
| import logging | |||
There was a problem hiding this comment.
testfiles should resamble concrete files. Issue: #32
…nchmark into feature/optuna-kube-bench
…ench' of github.com:gebauerm/ml_benchmark into feature/optuna-kube-bench
This reverts commit d05ed84.
This PR: