Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some little problems #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix some little problems #2

wants to merge 2 commits into from

Conversation

gaunthan
Copy link

@gaunthan gaunthan commented May 9, 2019

  1. The package name for 'cv2' should be 'opencv-python'
  2. Porting to python 3
  3. Allow the directory of input/output to be outside of the working directory

@aparico
Copy link

aparico commented Mar 15, 2022

@mjsobrep @varunagrawal Could you please merge this pull request?

@gaunthan
Copy link
Author

gaunthan commented Mar 15, 2022 via email

mjsobrep
mjsobrep requested changes Mar 15, 2022
View reviewed changes
Copy link
Member

@mjsobrep mjsobrep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small change: sanitize directory input.

camera_calibration/__init__.py
target_directory = os.path.join(os.getcwd(), directory)
directory_out = os.path.join(os.getcwd(), directory_out)
print "Searching for images in: " + target_directory
target_directory = directory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should sanitize with expand user

camera_calibration/__init__.py
for name in file_names:
print "\t" + name
print("\t" + name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great to at some point change all of these to f-strings, but not critical

@mjsobrep
Copy link
Member

@aparico I'm mostly OK with this. Just need to add something to the directory to appropriately sanitize it. Have you tested the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjsobrep mjsobrep mjsobrep requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaunthan @aparico @mjsobrep