Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Docker compose, now included in docker #968

Conversation

hkirk
Copy link
Contributor

@hkirk hkirk commented Oct 11, 2024

This fixes docker-compose for #962 for linux

Copy link

codeclimate bot commented Oct 11, 2024

Code Climate has analyzed commit f0f5521 and detected 0 issues on this pull request.

View more on Code Climate.

@prasadtalasila
Copy link
Contributor

@hkirk please include these changes into PR #964 and clone this PR

@hkirk
Copy link
Contributor Author

hkirk commented Oct 14, 2024

@hkirk please include these changes into PR #964 and clone this PR

Isn't merging these in small individual PRs easier, especially since Python VEnv and Docker compose have nothing in common?

@prasadtalasila
Copy link
Contributor

Too many small PRs are a problem as well. It would be great to resolve issue #962 in one PR. Thanks.

@hkirk hkirk closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants