Add 'Manage' tab to Digital Twins page preview #957

VanessaScherma · 2024-10-07T17:30:35Z

It replaces PR #906. it adds the 'Manage' tab to Digital Twins page preview. It includes the functionality ‘Details’ to read the README.md file, ‘Delete’ to delete the DT folder from the GitLab profile, ‘Reconfigure’ to edit the DT files.

codeclimate · 2024-10-07T17:31:23Z

client/src/preview/route/digitaltwins/editor/Sidebar.tsx

+  setConfigData(digitalTwin.configFiles.map((name) => ({ id: name, name })));
+};
+
+const handleFileClick = async (


Function handleFileClick has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

codeclimate · 2024-10-07T17:31:23Z

client/src/preview/route/digitaltwins/manage/ReconfigureDialog.tsx

+  setShowLog(false);
+};
+
+function ReconfigureDialog({


Function ReconfigureDialog has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

codeclimate · 2024-10-07T17:31:23Z

client/src/preview/route/digitaltwins/manage/ReconfigureDialog.tsx

+    setOpenCancelDialog(false);
+  };
+
+  const handleConfirmSave = async () => {


Function handleConfirmSave has 31 lines of code (exceeds 25 allowed). Consider refactoring.

prasadtalasila · 2024-10-08T15:58:29Z

@VanessaScherma remember to address issue #953

prasadtalasila · 2024-10-08T18:25:19Z

@VanessaScherma The tests are missing. Are you working on them?

prasadtalasila · 2024-10-09T15:41:47Z

Testcases and error messages to check for the PR:

Target gitlab project repo exists and public
Target gitlab project repo exists but private
Target gitlab project repo does not exist
User does not have access to the target gitlab project repo
Catch CORS error when trying to access the target gitlab project repo

Question: can these go into end-to-end tests or should these be manual tests for now?

VanessaScherma · 2024-10-09T16:05:04Z

@VanessaScherma The tests are missing. Are you working on them?

Yes, I will complete them as soon as possible.

codeclimate · 2024-10-09T16:18:53Z

client/src/preview/route/digitaltwins/manage/ReconfigureDialog.tsx

+  );
+}
+
+const saveChanges = async (


Function saveChanges has 27 lines of code (exceeds 25 allowed). Consider refactoring.

prasadtalasila · 2024-10-12T07:11:44Z

@VanessaScherma This PR brings nice working features. I am only half way through the code review and can suggest the following changes for now.

If there is a simple way (less than one hour of work) to introduce scroll behavior using up-down arrows that would be nice.
Please move this text
"This page demonstrates integration of DTaaS with gitlab CI/CD workflows. The feature is experimental and requires certain gitlab setup in order for it to work."
to top of page, i.e., before Manage-Execute react tabs.

The text for Manage and Execute Tabs is:
Manage: Check the Digital Twins and if necessary modify the same using reconfigure button.
The most useful modification is the reconfiguration of the Digital Twins.
Execute: Execute the Digital Twins using Gitlab CI/CD workflows.

When the side-menu opens, the order of items should be:

Description
  all markdown files
Configuration
  json and yaml files even dot files (at the moment the yaml files are not visible)
Lifecycle
  all the files available in lifecycle/ directory

Does the Manage tab load even if "description.md" does not exist for a DT? The description of
a digital twin could be left empty, if the matching "description.md" could not be found.
The editor/Sidebar.tsx uses dedicated SimpleTreeView for Description, Lifecycle and Configuration.
If a single SimpleTreeView is used for these three, then hiding of items is possible. Please
see the simple example on this MUI docs page

prasadtalasila · 2024-10-13T09:55:16Z

@VanessaScherma update to text description

To the top-of the DT preview page (before the React Tabs):
"This page demonstrates integration of DTaaS with gitlab CI/CD workflows. The feature is experimental and requires certain gitlab setup in order for it to work."

const tabs: ITabs[] = [
  {
  ...
  {
    label: 'Manage',
    body: `Read the complete description of digital twins. If necessary, users can delete a digital twin, removing it from the workspace with all its associated data. Users can also reconfigure the digital twin.`,
  },
  {
    label: 'Execute',
    body: 'Execute the Digital Twins using Gitlab CI/CD workflows.',
  },
  ...
];

prasadtalasila

@VanessaScherma The review is now complete. Please let me know when you are done with the changes and tests. Thanks.

prasadtalasila · 2024-10-12T08:37:14Z

client/src/preview/route/digitaltwins/manage/DetailsDialog.tsx

+  name: string;
+}
+
+const handleCloseLog = (setShowLog: Dispatch<SetStateAction<boolean>>) => {


Can this be named handleDetailsDialogue?

Changed into handleCloseDetailsDialog. The name of this function has been also changed accordingly in the other Dialogs.

prasadtalasila · 2024-10-12T08:39:43Z

client/src/preview/route/digitaltwins/editor/Sidebar.tsx

+import { selectDigitalTwinByName } from '../../../store/digitalTwin.slice';
+import DigitalTwin from '../../../util/gitlabDigitalTwin';
+
+interface SidebarProps {


These seem to be DTItemProps. These are rather the properties of a side bar item received from digital twin.

These are the props passed to the Sidebar component from the parent component Editor.

prasadtalasila · 2024-10-12T09:28:44Z

client/src/preview/components/asset/DeleteButton.tsx

+  setShowLog: Dispatch<React.SetStateAction<boolean>>;
+}
+
+const handleToggleLog = (setShowLog: Dispatch<SetStateAction<boolean>>) => {


The purpose of the function is unclear. The delete button is on Manage tab where there is no need for log dialogue.

The function has been renamed handleToggleDeleteDialog. Its purpose is to open the DeleteDialog component when the button is clicked.

prasadtalasila · 2024-10-12T09:30:49Z

client/src/preview/components/asset/DetailsButton.tsx

+  setShowLog: Dispatch<React.SetStateAction<boolean>>;
+}
+
+export const handleToggleLog = async (


Is it handleDetailsWindow?

The function has been renamed handleToggleDetailsDialog.

prasadtalasila · 2024-10-12T09:35:01Z

client/src/preview/components/asset/ReconfigureButton.tsx

+  setShowReconfigure: Dispatch<SetStateAction<boolean>>;
+}
+
+const handleToggleReconfigure = (


The Reconfigure button is never inactive. The original html page and all the related React components are active in the background. Is there a need to deactivate the Details button. Perhaps you intend to use this click action to show README in which case the code structure and names have to reflect that intention?

The function has been changed into handleToggleReconfigureDialog and it is used to open the ReconfigureDialog by clicking on the ReconfigureButton. Both the ReconfigureButton and the DetailsButton are never deactivated. If there are no files within the DT folder on GitLab, the ReconfigureDialog shows the empty SimpleTreeView (while maintaining the ‘Description’, ‘Lifecycle’, ‘Configuration’ sections). If there is no README.md, the DetailsDialog informs of the absence of that file within the GitLab folder. Is that what you mean?

yes, thanks.

An updated message: "There is no README.md file for the hello-world digital twin"

prasadtalasila · 2024-10-13T09:56:30Z

client/src/preview/components/asset/AssetBoard.tsx

+    {tab === 'Execute' ? (
+      <AssetCardExecute asset={asset} />
+    ) : (
+      <AssetCardManage asset={asset} onDelete={() => onDelete(asset.path)} />


There are also "details" and "reconfigure" buttons. Why are they treated differently from delete button?

The onDelete function is passed exclusively to AssetCardManage, which includes the Delete button. This is because it is the only button that, in addition to having an API call via gitlabDigitalTwin, must also modify the store via dispatch with the deleteAsset function.

prasadtalasila · 2024-10-13T10:20:52Z

client/src/preview/route/digitaltwins/editor/PreviewTab.tsx

+  fileType: string;
+}
+
+function PreviewTab({ fileContent, fileType }: PreviewProps) {


The md, json and yaml cases are handled. What happens if it is lifecycle/script?

The hidden files (starting with dot character) should also be available. This allows us to edit .gitlab-ci.yaml file as well.

Added case for handling bash files, without extension.

The yaml files are now included in the 'Configuration' section.

It is not just the bash files. Please show all the files placed in lifecycle directory

prasadtalasila · 2024-10-13T10:26:13Z

client/src/preview/route/digitaltwins/manage/DeleteDialog.tsx

+const handleDelete = async (
+  digitalTwin: DigitalTwin,
+  setShowLog: Dispatch<SetStateAction<boolean>>,
+  onDelete: () => void,


onDelete function is void everywhere in the codebase. Is it needed?

Yes, it does not have a return value but modifies the store via dispatch.

client/src/preview/util/gitlabDigitalTwin.ts

prasadtalasila · 2024-10-13T10:33:20Z

client/src/preview/util/gitlabDigitalTwin.ts

+      const filteredFiles = response
+        .filter(
+          (item: { type: string; name: string }) =>
+            item.type === 'blob' && item.name.endsWith('.json'),


The yaml file extension gets added here.

… manage

codeclimate · 2024-10-14T16:04:28Z

client/test/preview/unit/util/gitlabDigitalTwin.test.ts

+    );
+  });
+
+  it('should get description files', async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-14T16:04:28Z

client/test/preview/unit/util/gitlabDigitalTwin.test.ts

+    expect(dt.descriptionFiles).toEqual([]);
+  });
+
+  it('should get lifecycle files', async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-14T16:04:28Z

client/test/preview/unit/util/gitlabDigitalTwin.test.ts

+    expect(dt.lifecycleFiles).toEqual([]);
+  });
+
+  it('should get config files', async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-14T16:04:28Z

client/test/preview/unit/util/gitlabDigitalTwin.test.ts

+    expect(dt.descriptionFiles).toEqual(['file1.md']);
+  });
+
+  it('should return empty array when fetching description files fails', async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-14T16:04:28Z

client/test/preview/unit/util/gitlabDigitalTwin.test.ts

+    expect(dt.lifecycleFiles).toEqual(['file2.json']);
+  });
+
+  it('should return empty array when fetching lifecycle files fails', async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-14T16:12:37Z

client/test/preview/unit/util/gitlabDigitalTwin.test.ts

+    expect(dt.configFiles).toEqual(['file2.json']);
+  });
+
+  it('should return empty array when fetching config files fails', async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-14T16:12:37Z

client/test/preview/unit/routes/digitaltwins/editor/PreviewTab.test.tsx

+import * as React from 'react';
+
+describe('PreviewTab', () => {
+  it('renders PreviewTab with markdown content', () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-14T16:12:37Z

client/test/preview/unit/routes/digitaltwins/editor/PreviewTab.test.tsx

+    expect(screen.getByText('fileContent')).toBeInTheDocument();
+  });
+
+  it('renders PreviewTab with json content', () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-14T16:12:37Z

client/test/preview/unit/routes/digitaltwins/editor/PreviewTab.test.tsx

+    expect(screen.getByText('fileContent')).toBeInTheDocument();
+  });
+
+  it('renders PreviewTab with yaml content', () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-14T16:12:37Z

client/test/preview/unit/routes/digitaltwins/manage/ConfigDialog.test.tsx

+import { showSnackbar } from 'preview/store/snackbar.slice';
+import { mockDigitalTwin } from 'test/preview/__mocks__/global_mocks';
+
+jest.mock('react-redux', () => ({


Similar blocks of code found in 3 locations. Consider refactoring.

VanessaScherma · 2024-10-14T18:28:52Z

@VanessaScherma This PR brings nice working features. I am only half way through the code review and can suggest the following changes for now.

1. If there is a simple way (less than one hour of work) to introduce scroll behavior using up-down arrows that would be nice.

2. Please move this text
   "This page demonstrates integration of DTaaS with gitlab CI/CD workflows. The feature is experimental and requires certain gitlab setup in order for it to work."
   to top of page, i.e., before Manage-Execute react tabs.
   The text for Manage and Execute Tabs is:
   **Manage**: Check the Digital Twins and if necessary modify the same using _reconfigure_ button.
   The most useful modification is the reconfiguration of the Digital Twins.
   **Execute**: Execute the Digital Twins using Gitlab CI/CD workflows.

3. When the side-menu opens, the order of items should be:
   ```
   Description
     all markdown files
   Configuration
     json and yaml files even dot files (at the moment the yaml files are not visible)
   Lifecycle
     all the files available in lifecycle/ directory
   ```

4. Does the Manage tab load even if "description.md" does not exist for a DT? The description of
   a digital twin could be left empty, if the matching "description.md" could not be found.

5. The `editor/Sidebar.tsx` uses dedicated SimpleTreeView for Description, Lifecycle and Configuration.
   If a single SimpleTreeView is used for these three, then hiding of items is possible. Please
   see the simple example on [this MUI docs page](https://mui.com/x/react-tree-view/getting-started/#render-your-first-component)

Where should I enter the scroll behaviour? Within the ReconfigureDialog to scroll the different files? If so, it is already implemented using a single SimpleTreeView.
Done.
Done.
Done. Now the description remains empty if there is no description.md file.
Done.

codeclimate · 2024-10-15T10:48:50Z

client/test/preview/unit/util/gitlabDigitalTwinConfig.test.ts

+    dt = new DigitalTwin('test-DTName', mockGitlabInstance);
+  });
+
+  it('should get description files', async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-15T10:48:50Z

client/test/preview/unit/util/gitlabDigitalTwinConfig.test.ts

+    );
+  });
+
+  it('should get lifecycle files', async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-15T10:48:50Z

client/test/preview/unit/util/gitlabDigitalTwinConfig.test.ts

+    );
+  });
+
+  it('should get config files', async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-15T13:18:55Z

client/test/preview/unit/util/gitlabDigitalTwinConfig.test.ts

+    );
+  });
+
+  it('should get description files', async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-17T05:55:19Z

client/src/preview/route/digitaltwins/editor/Sidebar.tsx

+      }}
+    >
+      <SimpleTreeView>
+        <TreeItem itemId="description" label="Description">


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-17T05:55:19Z

client/src/preview/route/digitaltwins/editor/Sidebar.tsx

+          ))}
+        </TreeItem>
+
+        <TreeItem itemId="configuration" label="Configuration">


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-17T05:55:19Z

client/src/preview/route/digitaltwins/editor/Sidebar.tsx

+          ))}
+        </TreeItem>
+
+        <TreeItem itemId="lifecycle" label="Lifecycle">


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-17T05:55:19Z

client/test/preview/integration/route/digitaltwins/editor/Editor.test.tsx

+
+  const files = [{ name: 'Asset 1', content: 'content1', isModified: false }];
+
+  const store = configureStore({


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-17T05:55:19Z

client/test/preview/integration/route/digitaltwins/manage/Manage.test.tsx

+  { name: 'Asset 1', content: 'content1', isModified: false },
+];
+
+const store = configureStore({


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-20T15:27:14Z

client/test/preview/integration/route/digitaltwins/editor/Editor.test.tsx

+  const digitalTwin = new DigitalTwin('Asset 1', mockGitlabInstance);
+  digitalTwin.getFileContent = jest.fn().mockResolvedValueOnce(null);
+
+  await React.act(async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-20T15:27:14Z

client/test/preview/integration/route/digitaltwins/editor/Sidebar.test.tsx

+      jest.clearAllMocks();
+    });
+
+    it('calls handleFileClick when a description file is clicked', async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-20T15:27:14Z

client/test/preview/integration/route/digitaltwins/editor/Sidebar.test.tsx

+      });
+    });
+
+  it('calls handleFileClick when a configuration file is clicked', async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-20T15:27:14Z

client/test/preview/integration/route/digitaltwins/editor/Sidebar.test.tsx

+    });
+  });
+
+  it('calls handleFileClick when a lifecycle file is clicked', async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-20T15:27:14Z

client/test/preview/unit/routes/digitaltwins/editor/Sidebar.test.tsx

+    );
+  });
+
+  it('calls handleFileClick when a description file is clicked', async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-20T16:52:00Z

client/test/preview/unit/routes/digitaltwins/editor/Sidebar.test.tsx

+    fireEvent.click(file);
+  });
+
+  it('calls handleFileClick when a lifecycle file is clicked', async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-20T16:52:00Z

client/test/preview/integration/route/digitaltwins/editor/Sidebar.test.tsx

+    jest.clearAllMocks();
+  });
+
+  it('calls handleFileClick when a description file is clicked', async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-20T16:52:00Z

client/test/preview/unit/routes/digitaltwins/editor/Sidebar.test.tsx

+    fireEvent.click(file);
+  });
+
+  it('calls handleFileClick when a config file is clicked', async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-20T16:52:00Z

client/test/preview/integration/route/digitaltwins/editor/Sidebar.test.tsx

+    });
+  });
+
+  it('calls handleFileClick when a configuration file is clicked', async () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-20T16:52:00Z

client/test/preview/integration/route/digitaltwins/manage/Manage.test.tsx

@@ -0,0 +1,311 @@
+import AssetBoard from 'preview/components/asset/AssetBoard';


File Manage.test.tsx has 257 lines of code (exceeds 250 allowed). Consider refactoring.

codeclimate · 2024-10-20T17:20:40Z

client/test/preview/integration/route/digitaltwins/manage/DeleteDialog.test.tsx

+  }),
+});
+
+const setupTest = () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-20T17:20:40Z

client/test/preview/integration/route/digitaltwins/manage/DetailsDialog.test.tsx

+  }),
+});
+
+const setupTest = () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-20T17:20:40Z

client/test/preview/integration/route/digitaltwins/manage/ConfigDialog.test.tsx

+  }),
+});
+
+const setupTest = () => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-20T17:20:40Z

client/test/preview/integration/route/digitaltwins/manage/DeleteDialog.test.tsx

+  { name: 'Asset 1', content: 'content1', isModified: false },
+];
+
+const store = configureStore({


Similar blocks of code found in 4 locations. Consider refactoring.

codeclimate · 2024-10-20T17:20:40Z

client/test/preview/integration/route/digitaltwins/manage/DetailsDialog.test.tsx

+  { name: 'Asset 1', content: 'content1', isModified: false },
+];
+
+const store = configureStore({


Similar blocks of code found in 4 locations. Consider refactoring.

codeclimate · 2024-10-20T17:50:04Z

client/test/preview/integration/route/digitaltwins/manage/DeleteDialog.test.tsx

+describe('DeleteDialog', () => {
+  let store: ReturnType<typeof setupStore>;
+
+  beforeEach(() => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-20T17:50:04Z

client/test/preview/integration/route/digitaltwins/manage/DetailsDialog.test.tsx

+describe('DetailsDialog', () => {
+  let store: ReturnType<typeof setupStore>;
+
+  beforeEach(() => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2024-10-20T17:50:05Z

client/test/preview/integration/route/digitaltwins/manage/ConfigDialog.test.tsx

+describe('ReconfigureDialog', () => {
+  let store: ReturnType<typeof setupStore>;
+
+  beforeEach(() => {


Similar blocks of code found in 3 locations. Consider refactoring.

codecov · 2024-10-20T17:54:43Z

Codecov Report

Attention: Patch coverage is 82.41379% with 51 lines in your changes missing coverage. Please review.

Project coverage is 65.16%. Comparing base (eaa22d5) to head (78335aa).
Report is 36 commits behind head on feature/distributed-demo.

❗ Current head 78335aa differs from pull request most recent head dd7cc86

Please upload reports for the commit dd7cc86 to get more accurate results.

Files with missing lines	Patch %	Lines
client/src/preview/util/gitlabDigitalTwin.ts	32.65%	26 Missing and 7 partials ⚠️
...rc/preview/route/digitaltwins/editor/EditorTab.tsx	70.58%	4 Missing and 1 partial ⚠️
...c/preview/route/digitaltwins/editor/PreviewTab.tsx	80.00%	0 Missing and 3 partials ⚠️
.../src/preview/route/digitaltwins/editor/Sidebar.tsx	92.68%	0 Missing and 3 partials ⚠️
...preview/route/digitaltwins/DigitalTwinsPreview.tsx	0.00%	1 Missing and 1 partial ⚠️
...ew/route/digitaltwins/manage/ReconfigureDialog.tsx	95.91%	1 Missing and 1 partial ⚠️
client/src/preview/store/file.slice.ts	86.66%	0 Missing and 2 partials ⚠️
client/src/preview/store/digitalTwin.slice.ts	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@                     Coverage Diff                      @@
##           feature/distributed-demo     #957      +/-   ##
============================================================
- Coverage                     66.49%   65.16%   -1.33%     
============================================================
  Files                            31       59      +28     
  Lines                           394     1091     +697     
  Branches                         26       78      +52     
============================================================
+ Hits                            262      711     +449     
- Misses                          117      303     +186     
- Partials                         15       77      +62

Files with missing lines	Coverage Δ
client/src/page/Layout.tsx	`100.00% <ø> (ø)`
client/src/preview/components/asset/AssetBoard.tsx	`94.73% <100.00%> (ø)`
client/src/preview/components/asset/AssetCard.tsx	`100.00% <100.00%> (ø)`
...ient/src/preview/components/asset/DeleteButton.tsx	`100.00% <100.00%> (ø)`
...ent/src/preview/components/asset/DetailsButton.tsx	`100.00% <100.00%> (ø)`
...src/preview/components/asset/ReconfigureButton.tsx	`100.00% <100.00%> (ø)`
...ew/route/digitaltwins/DigitalTwinTabDataPreview.ts	`100.00% <ø> (ø)`
...t/src/preview/route/digitaltwins/editor/Editor.tsx	`100.00% <100.00%> (ø)`
...preview/route/digitaltwins/manage/DeleteDialog.tsx	`100.00% <100.00%> (ø)`
...review/route/digitaltwins/manage/DetailsDialog.tsx	`100.00% <100.00%> (ø)`
... and 14 more

... and 21 files with indirect coverage changes

Components	Coverage Δ
Website	`65.16% <74.13%> (-1.33%)`	⬇️
Lib Microservice	`∅ <ø> (∅)`

VanessaScherma · 2024-10-20T18:08:38Z

@prasadtalasila, here are updates on testing.

Rows uncovered, both in unit and integration tests:

158 of ReconfigureDialog (already mentioned at the last meeting). Although closing the Dialog is tested (and the test works correctly), the onClose line is not covered, unlike the other Dialogs present and tested.
20-24, 48 of EditorTab. onChange within the textbox is tested, however the rows are not covered due to the use of Monaco Editor. As read from this issue (link) it is not recommended to test Monaco Editor due to complexity, preferring to use other frameworks.

Also, there remains a duplication problem on CodeClimate. Despite having created a util function for store setup, the call to the function, followed by rendering the component, is considered duplication. Any ideas on how to fix this?

Thank you.

prasadtalasila · 2024-10-21T09:38:55Z

@prasadtalasila, here are updates on testing.

Rows uncovered, both in unit and integration tests:

158 of ReconfigureDialog (already mentioned at the last meeting). Although closing the Dialog is tested (and the test works correctly), the onClose line is not covered, unlike the other Dialogs present and tested.

20-24, 48 of EditorTab. onChange within the textbox is tested, however the rows are not covered due to the use of Monaco Editor. As read from this issue (link) it is not recommended to test Monaco Editor due to complexity, preferring to use other frameworks.

Also, there remains a duplication problem on CodeClimate. Despite having created a util function for store setup, the call to the function, followed by rendering the component, is considered duplication. Any ideas on how to fix this?

Thank you.

@VanessaScherma
Thanks for the updates. Please ignore codeclimate issues. The test coverage seems fine. I will have a look at the code one more time.

codeclimate · 2024-10-22T07:58:38Z

Code Climate has analyzed commit dd7cc86 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	3

View more on Code Climate.

Add manage tab

09ada15

codeclimate bot reviewed Oct 7, 2024

View reviewed changes

prasadtalasila mentioned this pull request Oct 8, 2024

Add 'Manage' tab to Digital Twins page preview #906

Closed

VanessaScherma and others added 2 commits October 8, 2024 16:52

Merge branch 'INTO-CPS-Association:feature/distributed-demo' into manage

cb4de3b

Add Lifecycle section in Reconfigure

5e9edaa

Render images, tables and mathematical notation in DetailsDialog

32a9914

Fix bug

912a9f1

Fix codeclimate issues

4818067

codeclimate bot reviewed Oct 9, 2024

View reviewed changes

VanessaScherma added 2 commits October 9, 2024 18:35

Fix codeclimate issue

42299ae

Update preview tab

c2773a8

prasadtalasila added this to the Release v0.6.0 milestone Oct 11, 2024

prasadtalasila reviewed Oct 13, 2024

View reviewed changes

vanessa added 4 commits October 14, 2024 14:09

Add unit tests

42a714a

Rename functions

939e621

Add yaml files to config files

d75e747

Merge branch 'manage' of https://github.com/VanessaScherma/DTaaS into…

d7ee4cc

… manage

codeclimate bot reviewed Oct 14, 2024

View reviewed changes

Little fix

413d396

codeclimate bot reviewed Oct 14, 2024

View reviewed changes

Add yml files to config files

4828566

VanessaScherma and others added 2 commits October 15, 2024 10:49

Update text description

a62b347

Update unit test

d957fbf

codeclimate bot reviewed Oct 15, 2024

View reviewed changes

Fix codeclimate issues

bae8bb7

codeclimate bot reviewed Oct 15, 2024

View reviewed changes

vanessa added 2 commits October 15, 2024 15:26

Fix codeclimate issue

fe2182f

Update tests

5c12f3f

codeclimate bot reviewed Oct 17, 2024

View reviewed changes

Complete integration tests

517ad1b

codeclimate bot reviewed Oct 20, 2024

View reviewed changes

Fix codeclimate issues

621775b

codeclimate bot reviewed Oct 20, 2024

View reviewed changes

Fix codeclimate issue

daebb10

codeclimate bot reviewed Oct 20, 2024

View reviewed changes

Fix codeclimate issues

78335aa

codeclimate bot reviewed Oct 20, 2024

View reviewed changes

Fix codeclimate issues

5ee7d39

VanessaScherma added 2 commits October 22, 2024 09:54

Updates

c6a7644

Update

dd7cc86

prasadtalasila merged commit 54f6dbe into INTO-CPS-Association:feature/distributed-demo Oct 22, 2024
4 checks passed

prasadtalasila mentioned this pull request Oct 22, 2024

DT Manage and Edit features #955

Closed

prasadtalasila mentioned this pull request Nov 11, 2024

[BUG] Error in yarn gitlab:run command #1000

Closed


		const files = [{ name: 'Asset 1', content: 'content1', isModified: false }];

		const store = configureStore({

		@@ -0,0 +1,311 @@
		import AssetBoard from 'preview/components/asset/AssetBoard';

Add 'Manage' tab to Digital Twins page preview #957

Add 'Manage' tab to Digital Twins page preview #957

Conversation

VanessaScherma commented Oct 7, 2024

codeclimate bot Oct 7, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 7, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 7, 2024

Choose a reason for hiding this comment

prasadtalasila commented Oct 8, 2024

prasadtalasila commented Oct 8, 2024

prasadtalasila commented Oct 9, 2024

VanessaScherma commented Oct 9, 2024

codeclimate bot Oct 9, 2024

Choose a reason for hiding this comment

prasadtalasila commented Oct 12, 2024

prasadtalasila commented Oct 13, 2024

prasadtalasila left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VanessaScherma Oct 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VanessaScherma Oct 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VanessaScherma Oct 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codeclimate bot Oct 14, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 14, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 14, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 14, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 14, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 14, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 14, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 14, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 14, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 14, 2024

Choose a reason for hiding this comment

VanessaScherma commented Oct 14, 2024

codeclimate bot Oct 15, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 15, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 15, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 15, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 17, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 17, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 17, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 17, 2024

VanessaScherma Oct 14, 2024 •

edited

Loading

VanessaScherma Oct 14, 2024 •

edited

Loading

VanessaScherma Oct 14, 2024 •

edited

Loading

codecov bot commented Oct 20, 2024 •

edited

Loading