Libms remove gitlab mode #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## feature/distributed-demo #435 +/- ##
=============================================================
+ Coverage 66.36% 82.07% +15.71%
=============================================================
Files 35 6 -29
Lines 440 106 -334
Branches 29 4 -25
=============================================================
- Hits 292 87 -205
+ Misses 130 15 -115
+ Partials 18 4 -14
... and 38 files with indirect coverage changes
|
- Updates diagrams to fit the latest codebase - Removes gitlab mode of lib microservice from documentation
prasadtalasila
force-pushed
the
libms-remove-gitlab-mode
branch
from
2bc08a6 to
4d70329
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -159,7 +159,8 @@ | |||
|
|
|||
| ??? Question "Does DTaaS support data collection from different sources like hardware, software and network? Is there any user interface or any tracking instruments used for data collection?" | |||
|
|
|||
| The DTaaS provids InfluxDB, RabbitMQ, MQTT services. Both the physical twin | |||
| The DTaaS provids InfluxDB, RabbitMQ, MQTT and MongoDB services. | |||
Adds screenshots of the new website. Minor updates to other parts of the documentation.
|
Code Climate has analyzed commit 06239d1 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
prasadtalasila
merged commit 105044c
into
INTO-CPS-Association:feature/distributed-demo
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gitlab mode of library microservice is broken.
It is removed from the codebase to make
library microservice functional again.
This PR partially addresses the problems mentioned in issues #167 and #218.
This PR also includes the code refactoring suggested in PR #326. Thanks @OliverGeneser for the work.