Makes minor improvements to PR-294 #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… publish-package-libms
…lish-package-libms
… feature/distributed-demo
… feature/distributed-demo
… feature/distributed-demo
- Adds package publication for runner - Updates READMEs of lib and runner microservices - Cleans up yarn commands of runner to make them cross-platform - Adds documentation for new example
removed typo added repo to test pre-commit test pre-commit with typo undo typo and uncomment mdlint test pre-commit with typo remove type test pre-commit uncomment format-check test dummy format test dummy commit dummies to git for test git diff test pre-commit eslint pre-commit config to replace custom pre-commit added directory lib to hooks test pre-commit yarn install yarn install logic to pre-commit prettified pre-commit-config added pre-push hooks test dummy pre-push test pre-push yarn jest test pre-push yarn jest test again test pre-push again test again TEST CORRECTLY test manual push another manual test test all pre-commit hooks added default hooks added pre-push test for lib test git hooks dir test git hooks dir test dir with dummie undo hook dir back to before test git hooks test git hooks test git hooks test git hooks test git hooks test git hooks test git hooks test git hooks test git hooks test git hooks test git hooks test git hooks reset after test test git hooks test git hooks test git hooks reset after test test git hooks reset after test test git hooks test git hooks reset after test test git hooks reset after test reset after test reset after test reset after test reset after test test script for git hooks done githook test and log for documentation reset after test reset after test reset after test reset after test reset after test reset after test reset after test reset after test test git hooks reset after test test git hooks reset after test test git hooks reset after test improved test went back to original test test git hooks final test script reset after test test git hooks reset after test reset after test reset after test reset after test reset after test test and log done added new githook script and updated guide comment out lib test hook stage markdownlint changes log githook run accept prettified changes updated run log removed logs and test from repo updated configure-git-hooks script and docs updated hook to use markdownlint/markdownlint removed unnecessary readme added prettier config to client undo change non trailling commas for client and lib undo trailing commas to test code cov Revert "undo trailing commas to test code cov" This reverts commit e5bf319. undo trailling commas to test codecov undo trailling commas in lib undo single quote prettier test undo semiconlons test remove trailling commas lib set traillingcomma all undo prettierrc accept prettier lib improves codecov accept prettier client improves codecov Swap ml-workspace container and improve docs (#300) - Replaces ml-workspace container with ml-workspace-minimal container. This change potentially improves the speed of user workspace. - Adds guide book to help with non-standard installation scenarios. - Adds MongoDB installation to services.js --------- Co-authored-by: nichlaes <[email protected]> Corrects docker commands and updates docs (#304) - Corrects docker run commands to always restart the containers - Updates diagrams in docs to include MongoDB - Adds yarn clean command to package.json of services. uncomment prettier replace deprecated code_blocks uncomment markdownlint fixed table mdl error ignore url line length mdl redo mdl hook ignore table line length and use .markdownlint.yaml instead replaced by pre-commit framework adhere to code climate linelength Adds scope to library tabs (#235 and #321) - Shows the right directory for each tab in Library page - Adds second level tabs to Library page. These tabs separate private and common assets --------- Co-authored-by: caesarv16 <[email protected]> Co-authored-by: s88004 <[email protected]> markdownlint disable codeblock test test deprecated code_blocks in codeclimate shortened comment to adhere to line_length
author lindot11 <[email protected]> 1701026896 +0100 committer Linda Nguyen <[email protected]> 1701283986 +0100 parent 7709e00 author lindot11 <[email protected]> 1701026896 +0100 committer Linda Nguyen <[email protected]> 1701283967 +0100 parent 7709e00 author lindot11 <[email protected]> 1701026896 +0100 committer Linda Nguyen <[email protected]> 1701283901 +0100 parent 7709e00 author lindot11 <[email protected]> 1701026896 +0100 committer Linda Nguyen <[email protected]> 1701283878 +0100 parent 7709e00 author lindot11 <[email protected]> 1701026896 +0100 committer Linda Nguyen <[email protected]> 1701283866 +0100 parent 7709e00 author lindot11 <[email protected]> 1701026896 +0100 committer Linda Nguyen <[email protected]> 1701283821 +0100 parent 7709e00 author lindot11 <[email protected]> 1701026896 +0100 committer Linda Nguyen <[email protected]> 1701283802 +0100 parent 7709e00 author lindot11 <[email protected]> 1701026896 +0100 committer Linda Nguyen <[email protected]> 1701283787 +0100 parent 7709e00 author lindot11 <[email protected]> 1701026896 +0100 committer Linda Nguyen <[email protected]> 1701283759 +0100 skip package upgrade added new githook script and updated guide comment out lib test hook log githook run updated run log removed logs and test from repo updated configure-git-hooks script and docs removed unnecessary readme added prettier config to client undo change non trailling commas for client and lib undo trailing commas to test code cov Revert "undo trailing commas to test code cov" This reverts commit e5bf319. test undo semiconlons set traillingcomma all undo prettierrc accept prettier lib improves codecov Corrects docker commands and updates docs (#304) - Corrects docker run commands to always restart the containers - Updates diagrams in docs to include MongoDB - Adds yarn clean command to package.json of services. uncomment prettier replaced by pre-commit framework adhere to code climate linelength markdownlint disable codeblock test test deprecated code_blocks in codeclimate shortened comment to adhere to line_length skip package upgrade Update docs and adds publication for runner (#275) - Adds package publication for runner - Updates READMEs of lib and runner microservices - Cleans up yarn commands of runner to make them cross-platform - Adds documentation for new example Fixes mistakes in the docs test git hooks test git hooks test git hooks test git hooks test git hooks test git hooks test git hooks test git hooks test git hooks test git hooks test git hooks test git hooks reset after test test git hooks test git hooks test git hooks reset after test test git hooks reset after test test git hooks test git hooks reset after test test git hooks reset after test reset after test reset after test reset after test reset after test test script for git hooks done githook test and log for documentation reset after test reset after test reset after test reset after test reset after test reset after test reset after test reset after test test git hooks reset after test test git hooks reset after test test git hooks reset after test improved test went back to original test test git hooks final test script reset after test test git hooks reset after test reset after test reset after test reset after test reset after test test and log done added new githook script and updated guide comment out lib test hook log githook run updated run log removed logs and test from repo updated configure-git-hooks script and docs updated hook to use markdownlint/markdownlint undo change non trailling commas for client and lib undo trailing commas to test code cov Revert "undo trailing commas to test code cov" This reverts commit e5bf319. undo trailling commas to test codecov undo trailling commas in lib undo single quote prettier test undo semiconlons test remove trailling commas lib set traillingcomma all undo prettierrc accept prettier lib improves codecov accept prettier client improves codecov Swap ml-workspace container and improve docs (#300) - Replaces ml-workspace container with ml-workspace-minimal container. This change potentially improves the speed of user workspace. - Adds guide book to help with non-standard installation scenarios. - Adds MongoDB installation to services.js --------- Co-authored-by: nichlaes <[email protected]> Corrects docker commands and updates docs (#304) - Corrects docker run commands to always restart the containers - Updates diagrams in docs to include MongoDB - Adds yarn clean command to package.json of services. uncomment prettier replace deprecated code_blocks uncomment markdownlint fixed table mdl error ignore url line length mdl redo mdl hook ignore table line length and use .markdownlint.yaml instead markdownlint disable codeblock test fix wrong reset action Revert "accept prettier client improves codecov" This reverts commit 924a5cd. Revert "skip package upgrade" This reverts commit ae8bea4.
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
|
||
| ```bibtex | ||
| @misc{talasila2023digital, | ||
| title={Digital Twin as a Service (DTaaS): A Platform for Digital Twin Developers and Users}, |
|
Code Climate has analyzed commit 8a3f5ec and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## feature/distributed-demo #344 +/- ##
============================================================
+ Coverage 63.47% 64.63% +1.15%
============================================================
Files 31 43 +12
Lines 397 574 +177
Branches 26 35 +9
============================================================
+ Hits 252 371 +119
- Misses 130 180 +50
- Partials 15 23 +8
... and 5 files with indirect coverage changes
|
prasadtalasila
merged commit 3080647
into
INTO-CPS-Association:feature/distributed-demo
6 checks passed
This was referenced Dec 3, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some markdown linting issues in PR #294