Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1093 bug wrong docker files for library microservice #1102

Conversation

nichlaes
Copy link
Collaborator

Libms fix docker files and readme

Type of Change

  • Bug fix
  • Documentation update

Description

Fixes

#1093
#1095

Testing

Will be tested through docker github action.

Impact

Github actions should work, and readme is updated to use new yaml config

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have added tests for all the new code and any changes made to
    existing code.
  • I have made corresponding changes to the documentation.

@nichlaes nichlaes linked an issue Dec 10, 2024 that may be closed by this pull request
@prasadtalasila prasadtalasila added this to the Release v0.7.0 milestone Dec 10, 2024
@prasadtalasila
Copy link
Contributor

@nichlaes please rebase to feature/distributed-demo branch

Copy link
Contributor

@prasadtalasila prasadtalasila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nichlaes please see the comments.

docker/compose.dev.yml Outdated Show resolved Hide resolved
servers/lib/DEVELOPER.md Show resolved Hide resolved
servers/lib/DEVELOPER.md Show resolved Hide resolved
servers/lib/config/libms.yaml.default Show resolved Hide resolved
servers/lib/config/libms.yaml.default Outdated Show resolved Hide resolved
docker/libms.npm.dockerfile Outdated Show resolved Hide resolved
@prasadtalasila prasadtalasila merged commit fc33c92 into feature/distributed-demo Dec 13, 2024
19 checks passed
@prasadtalasila prasadtalasila deleted the 1093-bug-wrong-docker-files-for-library-microservice branch December 13, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Wrong docker files for library microservice
2 participants