-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrates GitLab Runner into DTaaS #1082
base: feature/distributed-demo
Are you sure you want to change the base?
Integrates GitLab Runner into DTaaS #1082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aryanpingle Thanks for the PR. Please see the comments.
token = "xxx" | ||
executor = "docker" | ||
[runners.docker] | ||
tls_verify = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this solve the problem of self-generated certificates?
The The Now, if you try using |
* Standalone directory for the runner files * Separates the localhost and server compose files
a583833
to
721271f
Compare
@aryanpingle A related correction in the docs line-69 of deploy/services/gitlab/INTEGRATION.md file should be: If the DTaaS application is hosted at https://foo.com/, then configure the following files: |
1. Localhost Installation - You are using the integrated runner locally with | ||
a GitLab instance hosted at `https://localhost/gitlab`. | ||
2. Server Installation - You are using the integrated runner with a GitLab | ||
instance hosted on a production server. This server may be a remote server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(https://localhost/gitlab
)
please add this information in a separate section at the end of GITLAB-RUNNER.md |
Integrates GitLab Runner into DTaaS
Addresses #892 by integrating a GitLab Runner setup into the DTaaS software.
Type of Change
✔ New feature
✔ Documentation update
Description
Adds a
compose.runner.yml
file that spins up a Docker container running thegitlab/gitlab-runner
image, and automatically starts a gitlab runner based on the settings inconfig.toml
.Testing
Tested using a localhost and a server installation, both using a server-hosted gitlab instance.
Impact
The process of registering a GitLab Runner will be greatly simplified. Developers will be able to use the digital twins preview page with a self-hosted runner.
Additional Information
network_mode
is set tohost
for the gitlab-runner container. This should instead use or create a docker network.services/gitlab
directory.Checklist
existing code.