Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tasks in github actions #953

Open
prasadtalasila opened this issue Oct 5, 2024 · 5 comments
Open

More tasks in github actions #953

prasadtalasila opened this issue Oct 5, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@prasadtalasila
Copy link
Contributor

prasadtalasila commented Oct 5, 2024

The yarn format is missing in github actions. This needs to be added.

Please add the following task immediately after line-40 of client.yml

      - name: Run the formatting checks
        run: |
          yarn format

A heads up: any formatting violations needs to be caught in this task.

@prasadtalasila prasadtalasila added the bug Something isn't working label Oct 5, 2024
@prasadtalasila
Copy link
Contributor Author

Tests are missing for gitlab code in client.yml

@prasadtalasila
Copy link
Contributor Author

@VanessaScherma The following changes are required for package.json.

{
  ...
  "contributors": [
    ...
    "Cesar Vela",
    "Vanessa Scherma"
  ],
  ...
  "scripts": {
    "build": "npx react-scripts build",
    "clean": "npx rimraf build/ dist/ node_modules/ coverage/ playwright-report/ test-results/  test.svg src.svg src/util/gitlab.json",
    ...
    "develop": "npx react-scripts start",
    ...
    "gitlab:compile": "npx tsc --project tsconfig.gitlab.json",
    ...
  },
  ...
}

Please double check the proposed changes by running all the yarn commands suggested in DEVELOPER.md. Thanks.

@prasadtalasila
Copy link
Contributor Author

@VanessaScherma The following changes are required for package.json.

{
  ...
  "contributors": [
    ...
    "Cesar Vela",
    "Vanessa Scherma"
  ],
  ...
  "scripts": {
    "build": "npx react-scripts build",
    "clean": "npx rimraf build/ dist/ node_modules/ coverage/ playwright-report/ test-results/  test.svg src.svg src/util/gitlab.json",
    ...
    "develop": "npx react-scripts start",
    ...
    "gitlab:compile": "npx tsc --project tsconfig.gitlab.json",
    ...
  },
  ...
}

Please double check the proposed changes by running all the yarn commands suggested in DEVELOPER.md. Thanks.

Sorry this comment was to be put into PR #903. It has been copied there now.

@prasadtalasila
Copy link
Contributor Author

Also include yarn test:preview:unit and yarn test:preview:int in client.yml

@prasadtalasila
Copy link
Contributor Author

Also include yarn test:preview:unit and yarn test:preview:int in client.yml

completed in PR #958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant