-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More tasks in github actions #953
Comments
Tests are missing for gitlab code in client.yml |
@VanessaScherma The following changes are required for {
...
"contributors": [
...
"Cesar Vela",
"Vanessa Scherma"
],
...
"scripts": {
"build": "npx react-scripts build",
"clean": "npx rimraf build/ dist/ node_modules/ coverage/ playwright-report/ test-results/ test.svg src.svg src/util/gitlab.json",
...
"develop": "npx react-scripts start",
...
"gitlab:compile": "npx tsc --project tsconfig.gitlab.json",
...
},
...
} Please double check the proposed changes by running all the yarn commands suggested in |
Sorry this comment was to be put into PR #903. It has been copied there now. |
Also include |
completed in PR #958 |
The
yarn format
is missing in github actions. This needs to be added.Please add the following task immediately after
line-40
ofclient.yml
A heads up: any formatting violations needs to be caught in this task.
The text was updated successfully, but these errors were encountered: