Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab integration into installation #892

Open
prasadtalasila opened this issue Aug 26, 2024 · 6 comments
Open

Gitlab integration into installation #892

prasadtalasila opened this issue Aug 26, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@prasadtalasila
Copy link
Contributor

The new development in react client is pushing towards integrating Gitlab CI/CD integration. Thus there is a need to integrate gitlab and gitlab runner into the standard installation setup. A suggested integration structure is

new-installation

Of the given figure, the gitlab and runner containers are to be put into one docker compose package. The rest of containers need to be put into another docker compose package. The task on putting rest of containers into one docker compose is already complete. Only the gitlab and runner integration is pending.

@prasadtalasila
Copy link
Contributor Author

@aryanpingle this issue tracks your tasks. Please comment here if you require any clarification.

@aryanpingle
Copy link
Contributor

gitlab.js currently uses the configuration in gitlab.yml, so I'm thinking we can just use the DTaaS/docker/.env file with a new compose.gitlab.yml file like so:

# docker run -d \
#   --hostname ${gitlabConfig.hostname} \
#   --env EXTERNAL_URL=${gitlabConfig.url} \
#   --publish ${gitlabConfig.port}:80 \
#   --name gitlab \
#   --restart always \
#   --volume ${gitlabConfig.homedir}/config:/etc/gitlab:Z \
#   --volume ${gitlabConfig.homedir}/logs:/var/log/gitlab:Z \
#   --volume ${gitlabConfig.homedir}/data:/var/opt/gitlab:Z \
#   --shm-size 256m \
#   gitlab/gitlab-ce:16.4.1-ce.0

version: '3'
services:
  gitlab:
    image: gitlab/gitlab-ce:16.4.1-ce.0
    hostname: ${SERVER_DNS}
    restart: always
    volumes:
      - ${VAGRANT_GITLAB_DIR}/config:/etc/gitlab:Z
      - ${VAGRANT_GITLAB_DIR}/logs:/var/log/gitlab:Z
      - ${VAGRANT_GITLAB_DIR}/data:/var/opt/gitlab:Z
    shm_size: "256m"
    ports:
      - "8969:80" # from gitlab.yml
    environment:
      - EXTERNAL_URL=${SERVER_DNS}/gitlab

gitlab.yml contains this:

homedir: "/home/vagrant/DTaaS/deploy/services/gitlab" #no spaces in the path

Should we be using ${DTAAS_DIR}/deploy/services/gitlab instead? If not, we can just declare it (and port 8969) as a variable in this .env file

@aryanpingle
Copy link
Contributor

To clarify, compose.gitlab.yml is a temporary file to be used with docker-compose from the terminal, just until we create the local GitLab runner

@prasadtalasila
Copy link
Contributor Author

@aryanpingle

Should we be using ${DTAAS_DIR}/deploy/services/gitlab instead? If not, we can just declare it (and port 8969) as a variable in this .env file?

Let us put the gitlab compose file in docker directory existing at top-level (not the deploy/docker directory). Please place the required gitlab config files into docker/gitlab directory.

@prasadtalasila
Copy link
Contributor Author

@aryanpingle
The installation figure needs a bit of correction. The updated figure is:

DTaaS-install

@prasadtalasila
Copy link
Contributor Author

Partially completes this task via PRs #961 and #905. The runner integration is still pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In progress
Development

No branches or pull requests

2 participants