Fix SortedList.addAll(...) to be JLS compliant and provide unit tests #6046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CoreRasurae
commented
Oct 28, 2024
CoreRasurae
commented
- Fixes [Bug]: spoon.support.util.SortedList.addAll(...) return value is not JLS compliant #6034
- SortedList.addAll(...) should return a boolean value indicating if the Collection was modified is any way as a result of the call.
- Previously addAll(...) would return false if only partial changes occurred and would only return true if all elements had been inserted, or if adding an empty list which in not in accordance to the Java JLS/API as documented in https://docs.oracle.com/javase/8/docs/api/?java/util/Collections.html.
…ests (Fixes #6034) SortedList.addAll(...) should return a boolean value indicating if the Collection was modified is any way as a result of the call
…ncy-plugin to v3.8.1 (#6040) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….12 (#6042) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…yle-plugin to v3.6.0 (#6041) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Martin Wittlinger <[email protected]>
This ensures all builds are verifiable by https://www.sigstore.dev/. Co-authored-by: ludvigch <[email protected]>
…o v3.39.0 (#5977) * build(deps): update dependency org.eclipse.jdt:org.eclipse.jdt.core to v3.39.0 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Martin Wittlinger <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
Sorry i will redo all this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.