Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP(general feedback appreciated): fix/refactor(control-flow): Switch rework and multi-node statement changes #5742

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

WIP(general feedback appreciated): fix/refactor(control-flow): Switch rework and multi-node statement changes #5742

wants to merge 24 commits into from

Commits on Apr 10, 2024

  1. Add test case for correct switch behaviour with implicit default case

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    6362bce View commit details
    Browse the repository at this point in the history

  2. Handle implicit default case in control flow graph

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    0d775f5 View commit details
    Browse the repository at this point in the history

  3. Add test for correct handling of case statement with multiple express… 

    …ions
    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    3d5b626 View commit details
    Browse the repository at this point in the history

  4. Handle multiple case expressions 

    As a side effect, fall throughs now go to the next block, not the next case expression
    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    c706605 View commit details
    Browse the repository at this point in the history

  5. Control Flow helper top level javaDoc

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    ee5d7e7 View commit details
    Browse the repository at this point in the history

  6. Messages for assertTrues

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    8b7f609 View commit details
    Browse the repository at this point in the history

  7. Make Checkstyle happy

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    433c1c2 View commit details
    Browse the repository at this point in the history

  8. Properly represent return type in javadoc

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    27375a8 View commit details
    Browse the repository at this point in the history

  9. Add (failing) tests for correct switch control flow behaviour

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    4033929 View commit details
    Browse the repository at this point in the history

  10. First step merged switch rewrite

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    0ff9918 View commit details
    Browse the repository at this point in the history

  11. Rework graph layout (with case labels no separate blocks are created … 

    …anymore and handle return switch () {} expression
    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    6c24dc0 View commit details
    Browse the repository at this point in the history

  12. Rework handling of multinode statements 

    They now have a start and an end node. Should be ported to other multinode constructs like if, loops, conditionals, ...
    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    b27f6b8 View commit details
    Browse the repository at this point in the history

  13. Adjust tests to test structure instead of concrete node counts, chang… 

    …e switch selector node to branch
    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    211bf20 View commit details
    Browse the repository at this point in the history

  14. Remove unnecessary block wrapping

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    0326485 View commit details
    Browse the repository at this point in the history

  15. Temporarily adapt test to spoon bug

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f3b6591 View commit details
    Browse the repository at this point in the history

  16. Swap block begin and selector

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    10ab861 View commit details
    Browse the repository at this point in the history

  17. Fix test method name

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    06123b2 View commit details
    Browse the repository at this point in the history

  18. Detect exhaustive enum switches

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    bf03f1f View commit details
    Browse the repository at this point in the history

  19. Add missing code for exhaustiveness tests

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    cc473a1 View commit details
    Browse the repository at this point in the history

  20. Add test case for a constant true guard

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1b736ac View commit details
    Browse the repository at this point in the history

  21. Fix tests and complete exhaustiveness for java 21+

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    262ac4a View commit details
    Browse the repository at this point in the history

  22. Update tests

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    2caab71 View commit details
    Browse the repository at this point in the history

  23. Handle multi node statements in InitializedVariables

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    3c8e078 View commit details
    Browse the repository at this point in the history

  24. Remove bug workaround

    @Mr-Pine
    Mr-Pine committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    881371b View commit details
    Browse the repository at this point in the history