fix: keep track of declaring type for nested field accesses #5408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances readability by restructuring how the input resource 'Example' class is added in the 'testArrayLengthDeclaringTypeNested' method within FieldTest. The addition process is now within a single method call to 'addInputResource', improving code clarity and maintainability without altering functionality.
This commit addresses a potential null pointer exception in JDTTreeBuilderHelper.java. It occurred due to 'no classpath mode' which may cause variable 'b' to be null. By adding a null check, it ensures 'b' is not null before accessing its properties, increasing the stability of the program.
Added @nullable annotation to two functions in ReferenceBuilder.java and JDTTreeBuilderHelper.java. These functions are getVariableReference() in ReferenceBuilder and declaringType variable in JDTTreeBuilderHelper. The Nullable annotation is useful as the TypeBinding parameter can at times be null, particularly when running the program in 'no classpath' mode. This reduces the risk of throwing a null pointer exception and increases overall code robustness.
Disabled the AssignmentToNull check in qodana.yaml due to its lack of support for nullability annotations. Commented out the line to maintain code clarity for future reference. This change enhances program performance when running in 'no classpath' mode and prevents potential NullPointerException. It contributes to the overall robustness of the code.
I-Al-Istannen
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, nested field access led to
nulltype references in case ofarray.lengthaccesses. Passing the actual declaring type fixes that.Fixes #5199