Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set show_in_rest to true for region taxonomy. #92

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Set show_in_rest to true for region taxonomy. #92

merged 1 commit into from
Mar 11, 2020

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Mar 11, 2020 •
edited by joshdarby
Loading

Changes

This pull request makes the following changes:

  • Enables the Region taxonomy metabox in the Block Editor.

Why

For #90

Testing/Questions

Features that this PR affects:

  • The post editor

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?

Steps to test this PR:

  1. On the staging branch, view a post-type post's post editor. See the lack of a way to change a region on the post.
  2. Check out this branch.
  3. Refresh the editor page.
  4. You should now see the "Region" box in the "Document" pane of the editor.

@benlk benlk merged commit 7807c7e into staging Mar 11, 2020
@benlk benlk deleted the 90-regions-in-gutenberg branch March 11, 2020 21:54
@benlk benlk mentioned this pull request May 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdarby joshdarby joshdarby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benlk @joshdarby