Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digest page qa changes #91

Merged
merged 3 commits into from
Mar 12, 2020
Merged

Digest page qa changes #91

merged 3 commits into from
Mar 12, 2020

Conversation

joshdarby
Copy link

Changes

This pull request makes the following changes:

  • Moves "Go" search button to the end of the search form and changes text to "Search"
  • Adds outline border to Ninja forms widgets in digest archive sidebar
  • Sets all lists in newsletter signup form to be checked by default
    • This affects all newsletter signup forms on the site. Is this going to be ok with the client?
  • Increases checkbox size and label font size
  • Updates "Manage subscription" button font to match

Screen Shot 2020-03-11 at 4 29 25 PM

Screen Shot 2020-03-11 at 4 30 25 PM

Why

For #82

Testing/Questions

Features that this PR affects:

  • Digest page search
  • Digest page Nina Forms widget
  • Sitewide Mailchimp form

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?
  • This PR affects all newsletter signup forms on the site. Is this going to be ok with the client?

Steps to test this PR:

  1. View the digest page and make sure the new placement of the search button still works
  2. View the Mailchimp signup form and make sure all lists are checked by default
  3. View all widgets on digest page sidebar and make sure they look ok

@joshdarby joshdarby added this to the FRES-011 milestone Mar 11, 2020
@joshdarby joshdarby requested review from benlk and MirandaEcho March 11, 2020 20:32
@joshdarby joshdarby self-assigned this Mar 11, 2020
@@ -279,3 +279,11 @@ body.category-national {
color: @black;
}
}

.archive.category-digest {
#sidebar {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be applied to the homepage as well, or all pages?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this one should be since it would modify every btn-primary on their site, which they might not want.

@@ -249,6 +249,25 @@
margin-bottom: 0;
}
}
.archive.category-digest {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be applied to the homepage as well, or to all pages?

@joshdarby joshdarby merged commit 4c3cc9a into staging Mar 12, 2020
@benlk
Copy link
Collaborator

benlk commented Mar 12, 2020

:deployed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants