Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the homepage top post translatable. #103

Merged
merged 3 commits into from
May 13, 2020
Merged

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented May 11, 2020

Changes

This pull request makes the following changes:

Why

For #93

Testing/Questions

Features that this PR affects:

  • the homepage top post

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?
  • does switching languages change the language of the post displayed in the home top story location?

Steps to test this PR:

  1. With WPML installed and configured (I can give you a DB dump)
  2. View the homepage in English.
  3. Take the post in the homepage top story position (assuming it's English) and create a translation of that post in another language. The basics of post translation are touched upon at https://wpml.org/documentation/getting-started-guide/ and I used the Classic Translation editor for my test post https://wpml.org/documentation/translating-your-contents/using-the-translation-editor/
  4. View the homepage in that language. Is the translated post shown?

@benlk benlk added the Estimate: 8h < 8 Hours label May 11, 2020
@benlk benlk added this to the CARI-003 milestone May 11, 2020
@benlk benlk self-assigned this May 11, 2020
Copy link

@joshdarby joshdarby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this question, this looks good and works as expected.

@benlk benlk merged commit 6e25e0b into staging May 13, 2020
@benlk benlk deleted the 93-homepage-template-wpml branch May 13, 2020 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimate: 8h < 8 Hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants