Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some translated strings and add Grunt toolchain for translation files #101

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Apr 21, 2020

Changes

This pull request makes the following changes:

Why

For #96

Testing/Questions

Features that this PR affects:

  • labels on a couple blocks
  • grunt
  • things that were already tested in Largo

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?
  • what other testing is needed?

Steps to test the grunt toolkits:

  1. npm i
  2. grunt

Steps to test the translation stuff:

  1. Install https://wordpress.org/plugins/theme-check/ and run it against the caribbean theme
  2. The Theme Check results should not come back with any errors regarding translation.

@benlk benlk requested a review from joshdarby April 21, 2020 22:01
@benlk benlk self-assigned this Apr 21, 2020
@benlk
Copy link
Collaborator Author

benlk commented Apr 28, 2020

This has been updated to the latest Largo.

@benlk
Copy link
Collaborator Author

benlk commented Apr 29, 2020

This is deployed to staging.

@benlk benlk changed the base branch from master to staging April 29, 2020 21:39
@benlk benlk merged commit a6ff39f into staging Apr 29, 2020
@benlk benlk deleted the 96-translatability-improvements branch April 29, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant