Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work and updates to facilitate translation of the site via WPML plugin #96

Open
MirandaEcho opened this issue Apr 17, 2020 · 4 comments

Comments

@MirandaEcho
Copy link
Collaborator

We may need to make changes to Largo or to this child theme to ensure that all text is translatable

@benlk
Copy link
Collaborator

benlk commented Apr 21, 2020

  • run Theme Check plugin against caribbean
  • patch obvious problems in caribbean
  • add theme translation infrastructure from Largo to caribbean
  • address Largo translatability issues noted in Improve translatability WPBuddy/largo#1592

@benlk
Copy link
Collaborator

benlk commented Apr 21, 2020

One question for the client:

We can use Spain-Spanish with es_ES for now, but if there's a different one, it would be good to know.

@benlk
Copy link
Collaborator

benlk commented Apr 21, 2020

Note that Largo for Caribbean is already at 0.7-prerelease, so we can continue to work on Largo for Caribbean as necessary; it's just a matter of keeping track of what's changed in Largo since that last commit.

@benlk
Copy link
Collaborator

benlk commented Apr 23, 2020

Since the current Largo submodule commit f50df16e9e06fb9402802e2f1ce76ce058d26d76, here's what's changed in Largo trunk: WPBuddy/largo@f50df16...13e1777

CIJN has no styles regarding header-social, so that bit of the upgrade is straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants