-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homepage and interior styles refresh work #34
Open
benlk
wants to merge
96
commits into
staging
Choose a base branch
from
26-homepage-refresh
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on hold:
|
@kaylima The wireframes for the custom "Events" widget specify a "Sign Up" button: There's no guaranteed field for that in the event creation dialogs, but there is an "Event URL" field. Can we assume that that URL will always be a signup URL if it exists, or should the "Sign Up" text on the button instead be something like "More Info"? |
benlk
added a commit
to INN/umbrella-inndev
that referenced
this pull request
Jul 10, 2017
@benlk "More Info" is fine, thanks! |
benlk
added a commit
to INN/umbrella-inndev
that referenced
this pull request
Jul 11, 2017
…ility with base Largo. After movign all these layout changes to the two-column template, there's no reason to keep the one-column template around.
adding My Account section for nonprofit news database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP, placeholder request submitted to start the review process.
Changes
Upgrades
grunt-contrib-less
; please runnpm install
Redoes homepage layout:
span8
| span4 split, with custom styles for the image widget in the span8 and text widget in the span4span4 | span4 | span4
Homepage Middle widget area, with custom styles for a INN Next Event Widget in the first position1col
option with a two-columnspan4 | span8
design with the single widget area in the span8, with styles inless/common.less
so they can be picked up by theme revamps for the next refresh of INN sites. This also includes an all-white INN logo, powered by the new fileinc/common.php
and its plugged pluggable functioninn_logo()
.Wireframes that this is based on:
Post-deploy changes for inn.org
© Copyright %d, Institute for Nonprofit News
<b>
in the description for larger text