eth.Transaction: fix RequiredFields behavior for legacy transactions #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was spotted by @ggarri, the extra
return nilisn't needed and should be removed.I considered calling
RequiredFieldsinsideTransaction.UnmarshallJSONbut ultimately decided against that since it seemed like too much of a behavorial changes, and I can see a use case where someone wants to unmarshal are partial tx w/o error, and they can always call.RequiredFieldsseparately like I do in the unit test.I also noticed that two of the older unit tests were missing
chainIdfields so added those.