Assert > if/else

INCATools · Aug 21, 2024 · bca7a25 · bca7a25
1 parent 1d213c9
commit bca7a25
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/tests/test_implementations/test_semsimian_implementation.py b/tests/test_implementations/test_semsimian_implementation.py
@@ -173,13 +173,13 @@ def test_all_by_all_similarity_with_custom_ic_map(self):
         sim = (adapter.all_by_all_pairwise_similarity(entities, entities, predicates=self.predicates))
 
         for s in sim:
-            if s is not None:
-                if s.object_id == VACUOLE and s.subject_id == VACUOLE:
-                    self.assertEqual(s.ancestor_information_content, 5.5)
-                if s.object_id == ENDOMEMBRANE_SYSTEM and s.subject_id == ENDOMEMBRANE_SYSTEM:
-                    self.assertEqual(s.ancestor_information_content, 6.0)
-                if s.object_id == VACUOLE and s.subject_id == ENDOMEMBRANE_SYSTEM:
-                    self.assertEqual(s.ancestor_information_content, 0)
+            self.assertIsNotNone(s)
+            if s.object_id == VACUOLE and s.subject_id == VACUOLE:
+                self.assertEqual(s.ancestor_information_content, 5.5)
+            if s.object_id == ENDOMEMBRANE_SYSTEM and s.subject_id == ENDOMEMBRANE_SYSTEM:
+                self.assertEqual(s.ancestor_information_content, 6.0)
+            if s.object_id == VACUOLE and s.subject_id == ENDOMEMBRANE_SYSTEM:
+                self.assertEqual(s.ancestor_information_content, 0)
             else:
                 raise ValueError(f"Did not get similarity for got {s.object_id} and {s.subject_id}")