Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe #0032: Simplest Collection #371

Merged
merged 25 commits into from
Jan 19, 2024
Merged

Recipe #0032: Simplest Collection #371

merged 25 commits into from
Jan 19, 2024

Conversation

mathewjordan
Copy link
Member

@mathewjordan mathewjordan commented Dec 5, 2022

This PR addresses #32, creating a recipe for the simplest possible Collection.

@glenrobson
Copy link
Member

glenrobson commented Feb 2, 2023

Review by the Cookbook editors:

Use case

  • Could you reword the use case to give a user prespective and more direction on why you want to use a collection and also keep it simple. Could include links to other recipes for more complex use cases.

Implementation notes

Example

  • Could you use the Image service in the Manifests?

Restrictions

  • Add restriction that a collection structure is not for table of contents like interface although this maybe how the UV does it other viewers do it differently. For a table of contents example see: Multiple Volumes in a Single Bound Volume

Related recipes:

The editors would like to see the new version before it goes to the TRC.

@glenrobson glenrobson removed the meta: ready-for-editors Ready for Cookbook editor review label Apr 27, 2023
@mathewjordan mathewjordan mentioned this pull request Jun 4, 2023
@mathewjordan
Copy link
Member Author

@glenrobson @triplingual The updates in the Example section have been completed. The Clover bug noted earlier has been addressed as well. I did not that I could not figure out how Collections work in Annona. Unless I'm completely missing something, I don't know if it should be included as a supporting viewer. Best.

@triplingual
Copy link
Contributor

Annona works IIRC, but it's not the most obvious feature of it. (Short screencast for showing the Annona UI w/r/t collections)

@glenrobson
Copy link
Member

Hi Matt,

Sorry for not sending these comments out earlier but the editors are happy for this to go through. They asked if you could add Annona support for the collections. They also asked me to pass on that they believe the edits you've done since the last version have greatly improved the readability of the recipe.

Are you able to make the TRC call next Wednesday (15th of November) at 12:00pm ET? I will be sending out the issues and agenda on Monday.

Thanks for your work on this.

Glen

@mathewjordan
Copy link
Member Author

Hi Matt,

Sorry for not sending these comments out earlier but the editors are happy for this to go through. They asked if you could add Annona support for the collections. They also asked me to pass on that they believe the edits you've done since the last version have greatly improved the readability of the recipe.

Are you able to make the TRC call next Wednesday (15th of November) at 12:00pm ET? I will be sending out the issues and agenda on Monday.

Thanks for your work on this.

Glen

@glenrobson I made the update to add Annona to the list of supporting viewers. And yes, I'll be there for TRC on Wednesday! -Best

@mathewjordan
Copy link
Member Author

Annona works IIRC, but it's not the most obvious feature of it. (Short screencast for showing the Annona UI w/r/t collections)

Thank you @triplingual. I somehow missed that.

@mathewjordan
Copy link
Member Author

@glenrobson I believe I have made the change (link for behavior) required to publish this.

@glenrobson
Copy link
Member

Thanks Mat, looks great. Cheers Glen

@glenrobson glenrobson merged commit ee0709a into master Jan 19, 2024
1 check passed
@glenrobson glenrobson deleted the 0032-collection branch January 19, 2024 14:44
@glenrobson glenrobson linked an issue Jan 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: ready-for-editors Ready for Cookbook editor review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Simple Collections
3 participants