-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add editor hint support for trace #980
Conversation
made use in all conditional editors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean !isTraceHintAvailable()
in the is applicable block? Otherwise, you set the hint only when it is already set.
Might, be. Let me check. |
Now you made me think if we do even want to check in the editor hint in the precondition of the action. I don't think we want to deactive the action if the hint is already set. 🤔 |
I found the following points:
I totally agree with the editor hint for the Tracing Editor. The reason is explained here: #1005 So I would prefer using the approach of #1005. |
drop in favor of #1005 |
Fixes #974