Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editor hint support for trace #980

Closed
wants to merge 4 commits into from

Conversation

arimer
Copy link
Member

@arimer arimer commented Jun 17, 2024

Fixes #974

@arimer arimer requested a review from alexanderpann June 17, 2024 12:08
@arimer arimer requested a review from wsafonov as a code owner June 17, 2024 12:08
Copy link
Member

@alexanderpann alexanderpann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean !isTraceHintAvailable() in the is applicable block? Otherwise, you set the hint only when it is already set.

@arimer
Copy link
Member Author

arimer commented Jun 18, 2024

Might, be. Let me check.

@arimer
Copy link
Member Author

arimer commented Jun 18, 2024

Now you made me think if we do even want to check in the editor hint in the precondition of the action. I don't think we want to deactive the action if the hint is already set. 🤔

@arimer arimer changed the title Add editor hint support for trace Draft: Add editor hint support for trace Jun 18, 2024
@arimer arimer marked this pull request as draft June 18, 2024 12:03
@arimer arimer changed the title Draft: Add editor hint support for trace Add editor hint support for trace Jun 18, 2024
@mgronover
Copy link
Collaborator

I found the following points:

  1. The menu entries "show trace" and "stop trace" causes an influence on user settings in editor hints.

  2. I would suggest that we do not need a second point to activate/deactivate the trace explorer "show trace"/"stop trace". The Toolbar of the TraceExplorer can be used to hide the decorated code:
    image

I totally agree with the editor hint for the Tracing Editor. The reason is explained here: #1005

So I would prefer using the approach of #1005.

@arimer
Copy link
Member Author

arimer commented Jul 15, 2024

drop in favor of #1005

@arimer arimer closed this Jul 15, 2024
@arimer arimer deleted the refactor/trancingWithEditorHints branch September 18, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants