-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polling topic model #474
Open
markbotterill
wants to merge
28
commits into
main
Choose a base branch
from
polling-topic-model
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Polling topic model #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: lickem22 <[email protected]>
…ont display error state from redis
…non-neg queries + counted in dashboard
markbotterill
requested review from
lickem22,
amiraliemami and
tonyzhao6
as code owners
January 13, 2025 09:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @sidravi1 / @tonyzhao6 / @lickem22
Estimate: 45 mins
Ticket
Fixes: JIRA_TICKET_LINK
Description
Previously the Topic Modeling request took ~20-40 seconds. As per Amir's PR we now get nicer loading states. However, this is not best practice for FastAPI / production systems. We shouldn't need to increase time-outs (default @ 5s) to get around this.
Instead, we now kick of a background job and FastAPI instantly returns a "Job started" response. The progress of that job is then continuously written to the Redis (including fail states). If for any reason, the run fails, the user is given a notification and a reason in the frontend. Logs are also written to confirm in the backend.
I've also built on Amir's UI updates to track run states while being able to navigate between different time periods.
Goal
Reduce issues with deployment + make the UI experience smoother.
Changes
router.py
. This allows us to easily track where failures occur if a step doesn't complete.Future Tasks (optional)
Toast pop-ups can glitch slightly sometimes. (Lower priority)
Documentation probably needs updating -> full technical docs page for topic modeling needed.
How has this been tested?
Both with docker compose + local testing. Tests still run fine.
Steps to Test
add_dummy_data_to_db.py
in backend)To-do before merge (optional)
Checklist
Fill with
x
for completed.(Delete any items below that are not relevant)
scripts/
.github/workflows/