Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create function to return station metadata #54

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Create function to return station metadata #54

merged 3 commits into from
Jan 17, 2024

Conversation

lilyclements
Copy link
Collaborator

This PR should fix issue #50

@ChrisMarsh82 did you want to review this before I merge it in?

We do not have definitions or metadata for Malawi, this only returns for Zambia. Before testing, ensure that you have updated epicsadata

devtools::install_github("IDEMSInternational/epicsadata")

Then examples to test -

station_metadata(country = "zm", station_id = c("1", "33"), include_definitions = TRUE)
station_metadata()

@lilyclements
Copy link
Collaborator Author

lilyclements commented Jan 16, 2024

@ChrisMarsh82 to add - the failed test is from the issue we were having with the json file. I can confirm the other tests run fine on my machine. The json file problem is something I will investigate.

@lilyclements
Copy link
Collaborator Author

lilyclements commented Jan 16, 2024

@ChrisMarsh82 to add - I* managed to solve the problem with the tests always failing due to the json file. So, you can ignore my above statement! :D

*with the help of ChatGPT.

Look at those green ticks!

@lilyclements lilyclements merged commit b0f4a65 into main Jan 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant