Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding definitions_id option instead of station_id in definitions #122

Merged
merged 13 commits into from
Jun 5, 2024

Conversation

lilyclements
Copy link
Collaborator

@lilyclements lilyclements commented Jun 4, 2024

  • add_definitions_to_bucket - now updated. You can add the definitions to the bucket based on the ID
  • definitions - now updated. You can call the definitions based on the ID
  • annual_rainfall_summaries now updated
  • add_summaries_to_bucket and add_data_to_bucket still should remain that you call the station_id, not the definition (or we can do both station_id, ., definition_id for add_summaries_to_bucket (and when calling the summaries from the bucket)
  • Updated for r-instat functions
  • Update for all summaries - annual_temperature_rainfall, etc.
  • Check tests/fix any issues in tests

TODO

  • All data sets must be named in the metadata

fixes #121

@lilyclements lilyclements merged commit 7ee3410 into main Jun 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use definition_id instead of station_id
1 participant