Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emulate button, cleanup parameters and logging #25

Merged
merged 8 commits into from
Aug 20, 2024
Merged

Emulate button, cleanup parameters and logging #25

merged 8 commits into from
Aug 20, 2024

Conversation

tpoignonec
Copy link
Member

@tpoignonec tpoignonec commented Aug 20, 2024 •
edited
Loading

Major features in this PR:

  • Implement button emulation, see TODO: use dhdEmulateButton() #24
  • Add HW parameters for
    • interface_id, default = -1
    • emulate_button, default = false
    • fd_interface_name, default = fd_inertia
  • update ros2 control description

Minor changes:

  • cleanup logging using uniquely defined logger
  • add debug logs in fd_inertia_broadcaster and fd_clutch_broadcaster

@tpoignonec tpoignonec linked an issue Aug 20, 2024 that may be closed by this pull request
TODO: use dhdEmulateButton() #24
Closed
@tpoignonec tpoignonec added enhancement New feature or request backport-humble labels Aug 20, 2024
@tpoignonec tpoignonec self-assigned this Aug 20, 2024
@tpoignonec
Copy link
Member Author

tpoignonec commented Aug 20, 2024 •
edited
Loading

close #24

@tpoignonec tpoignonec merged commit 432de6d into main Aug 20, 2024
4 checks passed
@tpoignonec tpoignonec deleted the tpoignonec-add_debug_prints branch August 20, 2024 08:44
mergify bot pushed a commit that referenced this pull request Aug 20, 2024
@tpoignonec @mergify
Emulate button, cleanup parameters and logging (#25)
1bcbb41 
* add debug logs

* add parameters for emulate_button and interface_id

* make fd_inertia a parameter also

* emulate button

* update description file

* linting

* cleanup logging

(cherry picked from commit 432de6d)
@mergify mergify bot mentioned this pull request Aug 20, 2024
Merged
tpoignonec added a commit that referenced this pull request Aug 20, 2024
@mergify @tpoignonec
Emulate button, cleanup parameters and logging (#25) (#26)
295d123 
* add debug logs

* add parameters for emulate_button and interface_id

* make fd_inertia a parameter also

* emulate button

* update description file

* linting

* cleanup logging

(cherry picked from commit 432de6d)

Co-authored-by: Thibault Poignonec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tpoignonec tpoignonec

Labels
backport-humble enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TODO: use dhdEmulateButton()
1 participant
@tpoignonec