Fix controller spawn error #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: "No executable found" error when launching fd.launch.py - There's a space missing between "spawn" and "--controller-manager" - Use Node instead of ExecuteProcess to spawn controller - Remove ExecuteProcess import * style: organize imports in fd.launch.py
tpoignonec
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10
This unexpected behavior was introduced in #9:
forcedimension_ros2/fd_bringup/launch/fd.launch.py
Lines 92 to 95 in 0db5e5c
So the command is expanded as:
Where a space is missing between
spawnerand--controller-manager.I rewrite it using
Nodeinstead ofExecuteProcessin order to make code clearer and easier to debug.