Remove TestDbSuites. Run Query and Route tests directly. #276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
TestDbSuites
composite suite, which instantiates a singleTestDb
which is then shared bySparqlRouteTests
andSparqlTests
and cleaned up when they finish. Instead a newTestDb
is now instantiated in each of the tests that use it.The benefit of this is that we do not have to disable test discovery, which in my experience makes things like filtering on test name break, and makes the reporting less clear since it is always
TestDbSuites
that runs/fails and we don't see the runtime for each child test. It also seems to me that this increases parallelization, which is a benefit since these two tests seem to be the slowest in the total suite.What we lose compared to the old version is some extra work for setting up the
TestDb
twice, however from what I see this is negligible in relation to actually running the tests.Some rough numbers from my machine for reference:
Old: Clean build + test
Old: Re-run test
New: Clean build + test
New: Re-run test