Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): Update main-4.x #2118

Merged
merged 220 commits into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
220 commits
Select commit Hold shift + click to select a range
fef75da
Bump braces from 3.0.2 to 3.0.3 in /accessibility-checker-extension
dependabot[bot] Jun 17, 2024
10eea89
Merge branch 'master' into dependabot/npm_and_yarn/accessibility-chec…
ErickRenteria Jul 15, 2024
407cce8
Starter project
tombrunet Aug 2, 2024
7253048
Basic config files
tombrunet Aug 3, 2024
eb86a47
Config starter
tombrunet Aug 6, 2024
86ce40c
Merge branch 'master' into java2
tombrunet Aug 6, 2024
2936c7d
Process config files
tombrunet Aug 6, 2024
62c5400
Report signs of life
tombrunet Aug 7, 2024
5464d6c
First report
tombrunet Aug 8, 2024
fc99aa0
Baselines
tombrunet Aug 9, 2024
603b3a0
Scan summaries
tombrunet Aug 9, 2024
3cf03d4
Add jar build
tombrunet Aug 9, 2024
5b9c6c0
Merge branch 'master' into java2
tombrunet Aug 12, 2024
c4dd394
Merge branch 'master' into java2
tombrunet Aug 12, 2024
6ef30e8
Java test suite
tombrunet Aug 12, 2024
d363138
Add java test to PRs
tombrunet Aug 12, 2024
105622d
Make headless
tombrunet Aug 12, 2024
f7f0e3e
Git chromedriver
tombrunet Aug 12, 2024
1fc3cd5
debug
tombrunet Aug 12, 2024
72538c9
Add env
tombrunet Aug 12, 2024
b796bc7
Chrome driver dir
tombrunet Aug 12, 2024
cf70577
headless new
tombrunet Aug 12, 2024
c744a8f
debug
tombrunet Aug 12, 2024
71c19bf
debug
tombrunet Aug 12, 2024
3dd7077
Debug
tombrunet Aug 13, 2024
a18ad31
Set bin path
tombrunet Aug 13, 2024
ab39215
Fix test
tombrunet Aug 13, 2024
e70ef31
Output progress
tombrunet Aug 13, 2024
2458c28
change path
tombrunet Aug 13, 2024
b03f45f
Metrics and copyright
tombrunet Aug 13, 2024
f332d65
Don't record our own tests
tombrunet Aug 13, 2024
7d14a3a
Javadoc updates
tombrunet Aug 13, 2024
0af9784
Basic javadoc cleanup
tombrunet Aug 13, 2024
9464e4c
Test build
tombrunet Aug 13, 2024
92e73ab
yaml syntax
tombrunet Aug 13, 2024
cdaa7e3
working directory
tombrunet Aug 13, 2024
577b31c
Generate pom
tombrunet Aug 13, 2024
f7b122b
package write
tombrunet Aug 13, 2024
2f96ca1
switch token
tombrunet Aug 13, 2024
3362244
Generate pom
tombrunet Aug 13, 2024
d4e666f
Wrong gradle?
tombrunet Aug 13, 2024
b798ccc
creds
tombrunet Aug 13, 2024
eafb554
Add boilerplate
tombrunet Aug 13, 2024
e9fe1d1
Move files into equalaccess sub namespace
tombrunet Aug 13, 2024
d448817
Change boilerplate dependency version
tombrunet Aug 13, 2024
ef779d9
Flip expected, actual
tombrunet Aug 13, 2024
8ab3157
More isolation of selenium dependency
tombrunet Aug 14, 2024
255c209
CSV report / memory improvements
tombrunet Aug 15, 2024
a3d937a
A minimal issue params to the help urls
tombrunet Aug 15, 2024
0eb83ff
Tighten dependencies, IOException
tombrunet Aug 16, 2024
a6624cf
Tweak dependencies to not include selenium
tombrunet Aug 16, 2024
6f9615d
Do all of the 'pass' processing in the page context
tombrunet Aug 20, 2024
31d83ed
add test cases and update rule logic
shunguoy Aug 22, 2024
0dced3c
Do counting and "pass" filtering in the checking context
tombrunet Aug 23, 2024
3f496e4
typescript
tombrunet Aug 23, 2024
31fea34
Wrong variable
tombrunet Aug 23, 2024
b2670d4
Fix counting
tombrunet Aug 23, 2024
6de1516
Typescript bug
tombrunet Aug 23, 2024
a957835
init counts
tombrunet Aug 24, 2024
19f9112
fix count
tombrunet Aug 24, 2024
a011155
Handle large result
tombrunet Aug 24, 2024
60c3f7a
Debug
tombrunet Aug 24, 2024
6618d1a
Merge branch 'master' into java2
tombrunet Aug 24, 2024
4d480e5
update the rule and the test case result #1958
shunguoy Aug 26, 2024
1612590
adding id to link in reportTreeGrid
nam-singh Aug 26, 2024
d754d2b
stop propagation of containing div in reportTreeGrid
nam-singh Aug 26, 2024
048b680
Fix cypress baseline
tombrunet Aug 26, 2024
b6cbb5f
Bump axios from 1.7.3 to 1.7.4 in /rule-server (#1991)
dependabot[bot] Aug 26, 2024
1f151da
Bump axios from 1.6.8 to 1.7.4 in /accessibility-checker-extension/te…
dependabot[bot] Aug 26, 2024
475f36d
Bump micromatch from 4.0.7 to 4.0.8 in /report-react
dependabot[bot] Aug 26, 2024
826031c
update the rules #1958
shunguoy Aug 26, 2024
734bfcc
update the img_alt_null rule #1958
shunguoy Aug 27, 2024
b0e4ec2
Merge pull request #2009 from IBMa/issue-2006
ErickRenteria Aug 27, 2024
e0ec192
Merge pull request #2005 from IBMa/issue-1979
ErickRenteria Aug 27, 2024
821000a
update the baselines #1958
shunguoy Aug 28, 2024
555ca5d
update the baselines #1958
shunguoy Aug 28, 2024
932a638
update the help reference #1958
shunguoy Aug 28, 2024
1ec0962
Merge pull request #1935 from IBMa/dependabot/npm_and_yarn/accessibil…
ErickRenteria Aug 28, 2024
e5797a3
Bump axios from 1.6.2 to 1.7.5 in /cypress-accessibility-checker
dependabot[bot] Aug 28, 2024
ef24090
Bump webpack from 5.79.0 to 5.94.0 in /accessibility-checker-extension
dependabot[bot] Aug 28, 2024
c97e57e
Merge branch 'master' into dev-1958
tombrunet Aug 28, 2024
a690091
Merge branch 'master' into learnMore-2002-nam
drjoho Aug 28, 2024
721035f
Merge pull request #2018 from IBMa/learnMore-2002-nam
ErickRenteria Aug 29, 2024
847864d
Merge branch 'master' into dev-1958
philljenkins Aug 29, 2024
596a948
Merge pull request #2011 from IBMa/dev-1958
ErickRenteria Aug 29, 2024
dbea238
Rule server for 8-30
ErickRenteria Aug 30, 2024
71f2d9f
Merge branch 'master' into rule_server_8_28
ErickRenteria Aug 30, 2024
e186953
Merge pull request #2023 from IBMa/rule_server_8_28
ErickRenteria Aug 30, 2024
3d68dd8
added icons,changed css and bg color
nam-singh Aug 30, 2024
7d14e6e
Merge branch 'master' into dependabot/npm_and_yarn/accessibility-chec…
tombrunet Sep 3, 2024
b283b9c
Merge branch 'master' into dependabot/npm_and_yarn/cypress-accessibil…
tombrunet Sep 3, 2024
dc04c89
Merge branch 'master' into dependabot/npm_and_yarn/report-react/micro…
tombrunet Sep 3, 2024
00bfa8a
Switch from gradle to maven
tombrunet Sep 4, 2024
66f5921
fix maven test
tombrunet Sep 4, 2024
0b0b136
chromedriver missing in deploy
tombrunet Sep 4, 2024
ebdc304
corrected import and images
nam-singh Sep 4, 2024
dd0aff6
Start local rule server for testing
tombrunet Sep 4, 2024
b678c89
changes
nam-singh Sep 4, 2024
5b3a594
Deploy test
tombrunet Sep 4, 2024
5b82a22
correction in filter sort
nam-singh Sep 5, 2024
76e402a
seprating images
nam-singh Sep 5, 2024
9ca8a13
changes in utilimages
nam-singh Sep 5, 2024
fa3ef88
correction in expression of elements
nam-singh Sep 5, 2024
8ef1235
commenting hidden filter
nam-singh Sep 5, 2024
023a651
Merge branch 'master' into htmlReport-2019-nam
nam-singh Sep 5, 2024
e12ce3b
Try deploy from git
tombrunet Sep 5, 2024
fbc70c1
ioctl error
tombrunet Sep 5, 2024
e26e72d
Try another way to pass key
tombrunet Sep 5, 2024
db70f27
gpg import
tombrunet Sep 5, 2024
47c8988
import key
tombrunet Sep 5, 2024
9fbc81b
gpg
tombrunet Sep 5, 2024
4d9afb1
param order
tombrunet Sep 5, 2024
c036524
gpg loopback
tombrunet Sep 5, 2024
de9ef8d
Update common/module/src/report/ACReporterHTML.tsx
tombrunet Sep 5, 2024
570683c
Try jar package
tombrunet Sep 5, 2024
f16b80d
Rename ACReporterHTML.tsx to ACReporterHTML.ts
tombrunet Sep 5, 2024
b4a8e76
maven compiler props
tombrunet Sep 5, 2024
19b09d9
Setup release deployments for java checker
tombrunet Sep 5, 2024
75552a4
Add note to README
tombrunet Sep 5, 2024
881454d
Add Playwright support
tombrunet Sep 6, 2024
80c6d79
Add Playwright support
tombrunet Sep 6, 2024
77a003d
Starting javadoc
tombrunet Sep 6, 2024
5073a47
Merge branch 'master' into java2
tombrunet Sep 6, 2024
3ece6d8
Javadoc updates
tombrunet Sep 6, 2024
3193a0d
Enable playwrite screenshots, and report.toString
tombrunet Sep 6, 2024
f706bd0
Add copyright statement to javadoc
tombrunet Sep 6, 2024
5ca20e4
Fix for Firefox
tombrunet Sep 6, 2024
0d33acc
Fixes for Firefox
tombrunet Sep 6, 2024
cd24253
changes for hidden filter
nam-singh Sep 9, 2024
d85fd21
Merge pull request #1983 from IBMa/java2
ErickRenteria Sep 9, 2024
255cfa8
Merge branch 'master' into dependabot/npm_and_yarn/report-react/micro…
ErickRenteria Sep 9, 2024
805a52e
Merge branch 'master' into htmlReport-2019-nam
ErickRenteria Sep 9, 2024
851146b
Merge pull request #2014 from IBMa/dependabot/npm_and_yarn/report-rea…
ErickRenteria Sep 9, 2024
435f6ae
Merge branch 'master' into dependabot/npm_and_yarn/cypress-accessibil…
ErickRenteria Sep 9, 2024
ca33111
Merge pull request #2020 from IBMa/dependabot/npm_and_yarn/cypress-ac…
ErickRenteria Sep 10, 2024
51d3653
Merge branch 'master' into dependabot/npm_and_yarn/accessibility-chec…
ErickRenteria Sep 10, 2024
64121fb
Merge pull request #2021 from IBMa/dependabot/npm_and_yarn/accessibil…
ErickRenteria Sep 10, 2024
b4d1cee
changes for hidden icon
nam-singh Sep 10, 2024
826f984
correction in total issue
nam-singh Sep 10, 2024
2d45614
change in link text and css
nam-singh Sep 11, 2024
38f2452
css changes
nam-singh Sep 11, 2024
ae7128d
css changes
nam-singh Sep 11, 2024
e0f9216
css change
nam-singh Sep 11, 2024
90da546
Merge pull request #2027 from IBMa/htmlReport-2019-nam
ErickRenteria Sep 12, 2024
c3448a1
css changes
nam-singh Sep 12, 2024
7145590
set initial expand true and change filter order
nam-singh Sep 12, 2024
443b744
css changes
nam-singh Sep 12, 2024
e3fb49e
Fix artifact failures (#2038)
tombrunet Sep 12, 2024
7ec9ceb
Bump path-to-regexp and express in /report-react
dependabot[bot] Sep 12, 2024
1ef5205
Bump send and express in /rule-server
dependabot[bot] Sep 12, 2024
cfcd21c
Merge branch 'master' into htmlReportRelease
tombrunet Sep 12, 2024
3accf0d
Merge branch 'htmlReportRelease' into htmlReport-2026-nam
tombrunet Sep 12, 2024
b114e00
Bump serve-static and express in /report-react (#2043)
dependabot[bot] Sep 12, 2024
250d462
Merge pull request #2041 from IBMa/dependabot/npm_and_yarn/rule-serve…
ErickRenteria Sep 12, 2024
e3b54c3
Merge pull request #2040 from IBMa/dependabot/npm_and_yarn/report-rea…
ErickRenteria Sep 12, 2024
d842fe4
Bump body-parser and express in /rule-server (#2039)
dependabot[bot] Sep 12, 2024
0a36c96
Bump path-to-regexp and express in /rule-server (#2032)
dependabot[bot] Sep 12, 2024
275884a
Bump webpack from 5.76.3 to 5.94.0 in /report-react (#2044)
dependabot[bot] Sep 12, 2024
a8bdb6c
Bump braces from 3.0.2 to 3.0.3 in /common/module (#2031)
dependabot[bot] Sep 12, 2024
33199f1
Merge branch 'master' into bump-2024-09-12
tombrunet Sep 12, 2024
b20057d
Merge pull request #2034 from IBMa/htmlReport-2026-nam
ErickRenteria Sep 13, 2024
2f735d9
Merge pull request #2045 from IBMa/bump-2024-09-12
ErickRenteria Sep 13, 2024
274165d
css changes
nam-singh Sep 13, 2024
033b150
css changes
nam-singh Sep 13, 2024
e376c8d
score css change
nam-singh Sep 17, 2024
e53ff56
font weight of score
nam-singh Sep 17, 2024
99f7906
change in icon order and summary card border
nam-singh Sep 18, 2024
ef87616
color change for summary card
nam-singh Sep 18, 2024
e54b485
bg color of extenstion summ & border in html report
nam-singh Sep 18, 2024
ef801b9
Merge pull request #2049 from IBMa/htmlReport-2035-nam
ErickRenteria Sep 19, 2024
150a6d8
Merge branch 'master' into htmlReportRelease
philljenkins Sep 24, 2024
b9535bd
Update guides and screenshots for new interactive HTML reports
philljenkins Sep 25, 2024
f602cf8
add single quote
philljenkins Sep 26, 2024
44a9327
Add three 7.3 rules into the main policy
tombrunet Sep 30, 2024
00c5865
Update object verification
tombrunet Sep 30, 2024
9aa5f25
Fix label
tombrunet Sep 30, 2024
8543aa3
Update More info
philljenkins Sep 30, 2024
e412d5e
Default Oct 1, 2024
philljenkins Sep 30, 2024
52dda98
Default Oct 1, 2024
philljenkins Sep 30, 2024
c37beb4
Change label
tombrunet Oct 1, 2024
eb32d1e
Merge branch 'acc-req-7.3' of https://github.com/IBMa/equal-access in…
tombrunet Oct 1, 2024
91da1b0
Merge pull request #2056 from IBMa/htmlReportRelease
sct-will Oct 1, 2024
e8cae55
Merge branch 'master' into acc-req-7.3
philljenkins Oct 1, 2024
5bb8242
Merge pull request #2061 from IBMa/acc-req-7.3
ErickRenteria Oct 1, 2024
55280ae
update
ErickRenteria Oct 2, 2024
6249393
Update server
ErickRenteria Oct 2, 2024
90f6e53
Update archives.json
tombrunet Oct 2, 2024
9432462
Merge pull request #2063 from IBMa/Octoberserverupdate
ErickRenteria Oct 2, 2024
403b5d5
chore(engine): Generate a spreadsheet of rule mappings as an artifact…
tombrunet Oct 15, 2024
735ae80
Bump cookie and express in /report-react (#2073)
dependabot[bot] Oct 17, 2024
f501e3b
Bump markdown-to-jsx in /accessibility-checker-extension (#2072)
dependabot[bot] Oct 17, 2024
6b93959
Bump axios from 1.6.1 to 1.7.7 in /accessibility-checker-extension (#…
dependabot[bot] Oct 18, 2024
1b03640
Bump rollup from 2.75.6 to 2.79.2 in /report-react (#2059)
dependabot[bot] Oct 18, 2024
b339b03
Bump axios from 1.6.0 to 1.7.4 in /common/module (#2046)
dependabot[bot] Oct 18, 2024
abd9e3f
Cleanup sed version setting (#2075)
tombrunet Oct 18, 2024
4297d71
Bump http-proxy-middleware from 2.0.6 to 2.0.7 in /report-react (#2076)
dependabot[bot] Oct 28, 2024
72d5d27
fix(java): Fix exception when baseline has fewer issues than what is …
tombrunet Oct 29, 2024
53aba40
fix(engine): rule engine refactor and update (#2025)
shunguoy Nov 6, 2024
197c728
Create archive for Nov 6 (#2086)
tombrunet Nov 6, 2024
3c78d42
prevent unnecessary update (#2093)
nam-singh Nov 13, 2024
464d47d
fixrule(`aria_landmark_name_unique`): Change the accessible name leng…
shunguoy Nov 13, 2024
0b5921c
Bug found by DCS related to list, but cause by prevNode (#2094)
tombrunet Nov 13, 2024
d66bc88
Java baseline bug (#2097)
tombrunet Nov 13, 2024
d0ea23f
Create Nov 13 archive (#2098)
tombrunet Nov 13, 2024
dda9c2a
Update issue templates
sct-will Nov 22, 2024
9747478
Update pull_request_template.md
sct-will Nov 22, 2024
4560d7e
Bump cross-spawn from 7.0.3 to 7.0.6 in /report-react (#2105)
dependabot[bot] Nov 26, 2024
ce7be61
Update pull_request_template.md
sct-will Nov 26, 2024
5f9ddeb
Merge branch 'master' into sct-will-patch-1
sct-will Dec 3, 2024
7067e48
Merge branch 'master' into sct-will-patch-2
sct-will Dec 3, 2024
e3ed929
Merge pull request #2106 from IBMa/sct-will-patch-1
sct-will Dec 3, 2024
6fe18f7
Merge branch 'master' into sct-will-patch-2
sct-will Dec 3, 2024
8e8fc69
Merge pull request #2107 from IBMa/sct-will-patch-2
sct-will Dec 3, 2024
35de02f
update Issue templates yaml files (#2114)
sct-will Dec 4, 2024
681f77e
Use cache for visibility (#2112)
tombrunet Dec 4, 2024
257e8ca
Merge remote-tracking branch 'origin/main-4.x' into dev2-master-4.x
tombrunet Dec 5, 2024
90307bc
update the configuration files
shunguoy Dec 6, 2024
2388e01
update configuration files
shunguoy Dec 8, 2024
8b754c5
update configuration files
shunguoy Dec 8, 2024
a1d6434
update config files
shunguoy Dec 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
16 changes: 14 additions & 2 deletions .github/ISSUE_TEMPLATE/accessibility_issue.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ body:
- type: input
id: tool
attributes:
label: Automated testing tool and ruleset
label: Automated testing tool and ruleset.
description: 'Which tool and ruleset uncovered the issue?'
placeholder: e.g. IBM Equal Access Accessibility Checker - Latest Deployment
- type: input
Expand All @@ -77,4 +77,16 @@ body:
'How do we reproduce the accessibility violation you described?'
validations:
required: true

- type: markdown
attributes:
value: |
### Definition of Done
(DO NOT EDIT THIS SECTION. This section is for IBM internal use only.)
- [ ] Design artifacts reviewed
- [ ] Work item implemented
- [ ] Automated test case created (when applicable)
- [ ] Unit test completed
- [ ] Run Checker (when applicable)
- [ ] Manual and Screen Reader Testing (when applicable)
- [ ] Video recording of user experience walkthrough (if impact to UX)
- [ ] PR created
50 changes: 50 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''

---

**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Desktop (please complete the following information):**
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

**Smartphone (please complete the following information):**
- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]

**Additional context**
Add any other context about the problem here.


## Definition of Done
<!-- Do not modify this section. This section is for IBM internal use only. -->
- [ ] Design artifacts reviewed
- [ ] Work item implemented
- [ ] Automated test case created (when applicable)
- [ ] Unit test completed
- [ ] Run Checker (when applicable)
- [ ] Manual and Screen Reader Testing (when applicable)
- [ ] Video recording of user experience walkthrough (if impact to UX)
- [ ] PR created
14 changes: 14 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,18 @@ body:
'How do we reproduce the issue you described using the?'
validations:
required: true
- type: markdown
attributes:
value: |
### Definition of Done
(DO NOT EDIT THIS SECTION. This section is for IBM internal use only.)
- [ ] Design artifacts reviewed
- [ ] Work item implemented
- [ ] Automated test case created (when applicable)
- [ ] Unit test completed
- [ ] Run Checker (when applicable)
- [ ] Manual and Screen Reader Testing (when applicable)
- [ ] Video recording of user experience walkthrough (if impact to UX)
- [ ] PR created


16 changes: 15 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,20 @@
- [ ] This PR has been reviewed and is ready for test
- [ ] I understand that the title of this PR will be used for the next release notes.


### Assets to aide review attached
<!-- DO NOT EDIT THIS SECTION. This section is for IBM internal review only. Specify the additional artifacts that should be reviewed alongside this PR. -->
- [ ] Links to design artifacts
- [ ] Links to video walkthrough of user experience
- [ ] Other

### Definition of Done
<!-- DO NOT EDIT THIS SECTION. This section is for IBM internal review only. Verify that the following requirements are met prior to marking this PR (issue) as Done. -->
- [ ] Peer review complete
- [ ] Secondary review complete
- [ ] Staging deployment verified


<!--
-- TITLE INSTRUCTIONS START: DO NOT EDIT THIS SECTION --
The title of this PR will be used for release notes, please provide a relevant title.
Expand All @@ -35,4 +49,4 @@ The following templates should be used for the PR titles:

Please review more info: https://github.com/IBMa/equal-access/wiki/Release-notes
-- TITLE INSTRUCTIONS END --
-->
-->
6 changes: 3 additions & 3 deletions .github/workflows/master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
- run: npm run package:browser
working-directory: accessibility-checker-extension
- name: Upload packed extension
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
with:
name: accessibility-checker-extension for Chrome
path: accessibility-checker-extension/package/accessibility-checker-extension.zip
Expand All @@ -53,7 +53,7 @@ jobs:
- run: npm run package:browser
working-directory: accessibility-checker-extension
- name: Upload packed extension
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
with:
name: accessibility-checker-extension for Firefox
path: accessibility-checker-extension/package/accessibility-checker-extension.zip
Expand Down Expand Up @@ -92,7 +92,7 @@ jobs:
- run: npm test
working-directory: accessibility-checker/test-act-w3
- name: Upload packed extension
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
with:
name: ACT Text Results
path: accessibility-checker/test-act-w3/act-report-v2.txt
Expand Down
48 changes: 45 additions & 3 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ jobs:
- run: npm run package:browser
working-directory: accessibility-checker-extension
- name: Upload packed extension
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
with:
name: accessibility-checker-extension for Chrome
path: accessibility-checker-extension/package/accessibility-checker-extension.zip
Expand All @@ -195,7 +195,7 @@ jobs:
- run: npm run package:browser
working-directory: accessibility-checker-extension
- name: Upload packed extension
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
with:
name: accessibility-checker-extension for Firefox
path: accessibility-checker-extension/package/accessibility-checker-extension.zip
Expand All @@ -222,4 +222,46 @@ jobs:
BLUEMIX_USERID: apikey
BLUEMIX_PASS: ${{ secrets.BLUEMIX_PASS }}
CLOUD_PWD: ${{ secrets.CLOUD_PWD }}
TRAVIS_BRANCH: prod
TRAVIS_BRANCH: prod

java-accessibility-checker-deploy:
runs-on: ubuntu-22.04
permissions:
packages: write
strategy:
matrix:
node-version: [18.x]

steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v4
with:
distribution: 'semeru' # See 'Supported distributions' for available options
java-version: '17'
server-id: central
server-username: ${{ secrets.MVN_GITHUB_USER }}
server-password: ${{ secrets.MVN_GITHUB_TOKEN }}
- uses: s4u/[email protected]
with:
servers: |
[{
"id": "central",
"username": "${{ secrets.MVN_GITHUB_USER }}",
"password": "${{ secrets.MVN_GITHUB_TOKEN }}"
}]
- name: Configure GPG Key
run: echo "$GPG_SIGNING_KEY" >private.key
env:
GPG_SIGNING_KEY: ${{ secrets.GPG_SIGNING_KEY }}
- name: Import GPG Key
run: gpg --pinentry-mode=loopback --passphrase "$GPG_SIGNING_KEY_PASS" --import private.key
env:
GPG_SIGNING_KEY_PASS: ${{ secrets.GPG_SIGNING_KEY_PASS }}
- name: Set version
run: sed -i'.old' -e 's/<version>3\.0\.0<\/version>/<version>'"${GITHUB_REF:10}"'<\/version>/g' ./pom.xml
working-directory: java-accessibility-checker
- name: Publish package
run: mvn --batch-mode deploy -DskipTests -Dgpg.passphrase=$GPG_SIGNING_KEY_PASS
working-directory: java-accessibility-checker
env:
GPG_SIGNING_KEY_PASS: ${{ secrets.GPG_SIGNING_KEY_PASS }}
84 changes: 80 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,15 @@ jobs:
- run: npx mocha ./test/mocha/help/help.test.js
working-directory: accessibility-checker-engine
- name: Upload rule listing
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
with:
name: Rule listing
path: accessibility-checker-engine/dist/help/rules.html
- name: Upload rule mapping spreadsheet
uses: actions/upload-artifact@v4
with:
name: Rule mapping spreadsheet
path: accessibility-checker-engine/dist/help/rules.csv


act-results:
Expand Down Expand Up @@ -84,7 +89,7 @@ jobs:
- run: npm test
working-directory: accessibility-checker/test-act-w3
- name: Upload packed extension
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
with:
name: ACT Text Results
path: accessibility-checker/test-act-w3/act-report-v2.txt
Expand Down Expand Up @@ -361,6 +366,77 @@ jobs:
- run: npm run wdio
working-directory: accessibility-checker/test/webdriverio

###############################################################################
# Java test
####
java-accessibility-checker-selenium-test:
runs-on: ubuntu-22.04

strategy:
matrix:
node-version: [18.x]

steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v4
with:
distribution: 'semeru' # See 'Supported distributions' for available options
java-version: '17'
- name: Latest Chrome
uses: browser-actions/setup-chrome@v1
with:
chrome-version: latest
install-chromedriver: true
id: setup-chrome
- run: npm install
working-directory: rule-server
- run: npm run build
working-directory: rule-server
- run: node main.js &
working-directory: rule-server/dist
- run: sleep 10
working-directory: rule-server/dist
- name: Test package
run: mvn --batch-mode test -Dtest="AccessibilityCheckerSeleniumTest"
working-directory: java-accessibility-checker
env:
chromedriverpath: ${{ steps.setup-chrome.outputs.chromedriver-path }}
chromebinpath: ${{ steps.setup-chrome.outputs.chrome-path }}

java-accessibility-checker-playwright-test:
runs-on: ubuntu-22.04

strategy:
matrix:
node-version: [18.x]

steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v4
with:
distribution: 'semeru' # See 'Supported distributions' for available options
java-version: '17'
- name: Latest Chrome
uses: browser-actions/setup-chrome@v1
with:
chrome-version: latest
install-chromedriver: true
id: setup-chrome
- run: npm install
working-directory: rule-server
- run: npm run build
working-directory: rule-server
- run: node main.js &
working-directory: rule-server/dist
- run: sleep 10
working-directory: rule-server/dist
- name: Test package
run: mvn --batch-mode test -Dtest="AccessibilityCheckerPlaywrightTest"
working-directory: java-accessibility-checker
env:
chromedriverpath: ${{ steps.setup-chrome.outputs.chromedriver-path }}
chromebinpath: ${{ steps.setup-chrome.outputs.chrome-path }}

###############################################################################
# Karma Tests
####
Expand Down Expand Up @@ -491,7 +567,7 @@ jobs:
run: npm test
working-directory: accessibility-checker-extension/test
- name: Upload packed extension
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
with:
name: accessibility-checker-extension for Chrome
path: accessibility-checker-extension/package/accessibility-checker-extension.zip
Expand All @@ -500,7 +576,7 @@ jobs:
- run: npm run package:browser
working-directory: accessibility-checker-extension
- name: Upload packed extension
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
with:
name: accessibility-checker-extension for Firefox
path: accessibility-checker-extension/package/accessibility-checker-extension.zip
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,16 @@ <h3 id="ruleMessage"></h3>

### Why is this important?

A `<label>` element is attached to a specific `<input>` element through the `for` attribute.
When a `<label>` does not reference the corresponding unique `id` in a valid `<input>` element,
A `<label>` element is attached to a specific element, such as `<input>` and `<select>`, through the `for` attribute.
When a `<label>` does not reference the corresponding unique `id` in a valid element,
assistive technologies cannot associate the label with the element.

<!-- This is where the code snippet is injected -->
<div id="locSnippet"></div>

### What to do

* Set the value of the `for` attribute to the `id` value of the valid `<input>` element to be labeled. Make sure the `id` value is unique.
* Set the value of the `for` attribute to the `id` value of the valid element to be labeled. Make sure the `id` value is unique.

For example:

Expand Down
8 changes: 5 additions & 3 deletions accessibility-checker-engine/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,13 @@
// { pattern: 'test/v2/checker/accessibility/rules/Rpt_Aria_RequiredParent_Native_Host_Sematics_ruleunit/ACT_ff89c9_pass4.html', watched: true },
//{ pattern: 'test/v2/checker/accessibility/rules/label_name_visible_ruleunit/label_offscreen.html', watched: true },
//{ pattern: 'test/v2/checker/accessibility/rules/aria_role_valid_ruleunit/td_attribute_invalid_copy.html', watched: true },
//{ pattern: 'test/v2/checker/accessibility/rules/label_name_visible_ruleunit/label_multiple_offscreen.html', watched: true },
//{ pattern: 'test/v2/checker/accessibility/rules/text_block_heading_ruleunit/Headings-noneUsedEmphasizedText.html', watched: true },
{ pattern: 'test/v2/checker/accessibility/rules/aria_landmark_name_unique_ruleunit/*.html', watched: true },
// { pattern: 'test/v2/checker/accessibility/rules/aria_parent_required_ruleunit/webComponentPass2.html', watched: true },


{ pattern: 'test/**/*_ruleunit/*.html', watched: true },
{ pattern: 'test/**/*_ruleunit/*.htm', watched: true },
// { pattern: 'test/**/*_ruleunit/*.html', watched: true },
// { pattern: 'test/**/*_ruleunit/*.htm', watched: true },
// all files ending in "_test"
// { pattern: 'test/*_test.js', watched: true },
{ pattern: 'test/**/*_test.js', watched: true }
Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker-engine/karmaaction.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ module.exports = (config) => {
customLaunchers: {
ChromeCustom: {
base: 'ChromeHeadless',
flags: ['--disable-web-security', '--no-sandbox']
flags: ['--disable-gpu', '--disable-web-security', '--no-sandbox']
}
},
preprocessors: {
Expand Down
Loading