Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(element_accesskey_labelled) fix the label requirement for the elements with accesskey attribute #1773

Merged
merged 7 commits into from
Dec 14, 2023

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Dec 6, 2023

  • New or modified help files: element_accesskey_labelled
  • Rule bug: element_accesskey_labelled

This PR is related to the following issue(s):

#916
#1772

Additional information can be found here:

Testing reference:

test case: test/v2/checker/accessibility/rules/element_accesskey_labelled_ruleunit/form_control_accesskey.html
After the fix, the Recommendation messages: "The HTML element with an assigned 'accesskey' attribute does not have an associated label" should be gone.

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@philljenkins
Copy link
Contributor

philljenkins commented Dec 7, 2023

@shunguoy how do we fix the wdio automated testing bug for this branch/PR?

I just re-ran the job, with logging turned on, and now it has passed. So it is some king of a timing error.

@shunguoy shunguoy requested a review from tombrunet December 7, 2023 16:44
@ErickRenteria
Copy link
Contributor

Validated

@ErickRenteria ErickRenteria merged commit 4be30c1 into master Dec 14, 2023
15 checks passed
@shunguoy shunguoy deleted the dev-916 branch January 5, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants