Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine): Mapping to SCs incorrect for ACT report #1721

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix(engine): Mapping to SCs incorrect for ACT report #1721

merged 1 commit into from
Oct 18, 2023

Conversation

tombrunet
Copy link
Member

  • Other (Provide information)
    Wilco reported that we were mapping results to all SCs. Our code for generating the ACT report had some syntax errors.

This PR is related to the following issue(s):

Additional information can be found here:

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@tombrunet tombrunet marked this pull request as ready for review October 18, 2023 15:48
@ErickRenteria ErickRenteria merged commit 98547b3 into master Oct 18, 2023
15 checks passed
@tombrunet tombrunet deleted the act-report-bug branch April 11, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErickRenteria ErickRenteria ErickRenteria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tombrunet @ErickRenteria