Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(node|karma|express): Add support for a "versioned" ruleArchive configuration option #1687

Merged
merged 5 commits into from
Sep 19, 2023

Conversation

tombrunet
Copy link
Member

@tombrunet tombrunet commented Sep 19, 2023

  • Other (Provide information)

This PR is related to the following issue(s):

Additional information can be found here:

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@tombrunet tombrunet marked this pull request as ready for review September 19, 2023 15:21
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense in the context of the Readme.:

If "latest", will use the latest rule release
If "versioned" (supported in 3.1.61+), will use the latest rule release at the time this version of the tool was released.

@ErickRenteria ErickRenteria merged commit 26352c7 into master Sep 19, 2023
14 of 15 checks passed
@ErickRenteria ErickRenteria deleted the issue1662 branch January 3, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants