Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table_headers_exists): fix issues related to the case of multiple headers for both rows and columns #1594

Merged
merged 15 commits into from
Sep 18, 2023

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Aug 21, 2023

fix(table_headers_exists): fix issues related to the case of multiple headers for both rows and columns

Please review more info: https://github.com/IBMa/equal-access/wiki/Release-notes -->

Rule bug: table_headers_exists

This PR is related to the following issue(s):

#1472

Testing reference:

  1. test/v2/checker/accessibility/rules/table_headers_exists_ruleunit/table_multiple_headers.htm
  2. test/v2/checker/accessibility/rules/table_headers_exists_ruleunit/table_headers_row_association.htm
    Notice that the violation "Table has no headers identified" was fixed.

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy requested a review from tombrunet August 30, 2023 14:34
@shunguoy shunguoy marked this pull request as ready for review August 30, 2023 14:37
@ErickRenteria
Copy link
Contributor

Undet test

@ErickRenteria ErickRenteria merged commit a55b157 into master Sep 18, 2023
15 checks passed
@ErickRenteria ErickRenteria deleted the dev-1472 branch January 3, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants