Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: A11Y Checker not handling the case of multiple headers for both rows and columns. #1472

Closed
fbarroso24 opened this issue May 25, 2023 · 5 comments
Assignees
Labels
development engine Issues in the accessibility-checker-engine component false-positive Rules incorrectly reporting a violation priority-2 (med) Ready for QA SME Discuss with subject matter experts user-reported Issues identified outside of the core team

Comments

@fbarroso24
Copy link

Project

a11y checker

Browser

Chrome

Operating system

Windows

Description

We found a bug in Accessibility checker tool.

We have a complex table where multiple rows & columns act as headers (see screenshot).
image

The Accessibility Checker is showing a 1.3.1: Info & Relationships violation wrt Table has no headers identified.

That being said, we already appear to be implementing the proposed solution by using id attribute in the <th> elements and the headers attribute in the td cells. (see above pic).

Given the above, we believe this is a false-positive violation due to the A11Y checker not handling the case of multiple headers for both rows and columns.

Here is a sample HTML to help illustrate the scenario.
complexTable.zip

It's essentially the raw HTML to represent a complex chart like.
image
NOTE: Given that .js & .css files are not included, the output of the sample HTML file will look a bit different.

Steps to reproduce

Run A11Y checker on a complex table that includes multiple header rows & multiple header columns.
complexTable.zip

@philljenkins philljenkins added the user-reported Issues identified outside of the core team label May 25, 2023
@philljenkins
Copy link
Contributor

See the discussion on Slack at https://ibm-studios.slack.com/archives/C036P1CTN/p1684856928127849
also the separate reply:
"We're going to have to dig a little more. Data tables are generally not expected to have the headers on the bottom."

@marcjohlic marcjohlic added engine Issues in the accessibility-checker-engine component extension-checker Issues related to the browser extensions labels May 30, 2023
@philljenkins philljenkins added SME Discuss with subject matter experts development false-positive Rules incorrectly reporting a violation and removed extension-checker Issues related to the browser extensions labels May 30, 2023
@shunguoy
Copy link
Contributor

shunguoy commented Jun 5, 2023

triage: the current rule only allows the headers in the first row, and empty cell in the left. also need to consider when table header is in the bottom of the data table.

@shunguoy
Copy link
Contributor

for @tombrunet review

@ErickRenteria
Copy link
Contributor

@shunguoy unable to test due to #1684

@ErickRenteria
Copy link
Contributor

This seem to be working correctly now.
Screenshot 2023-09-18 115248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development engine Issues in the accessibility-checker-engine component false-positive Rules incorrectly reporting a violation priority-2 (med) Ready for QA SME Discuss with subject matter experts user-reported Issues identified outside of the core team
Projects
None yet
Development

No branches or pull requests

6 participants