Bug found by DCS related to list, but cause by prevNode (#2094)

Co-authored-by: Shunguo Yan <[email protected]>
IBMa · Dec 3, 2024 · f32af03 · f32af03
1 parent 65e6cf6
commit f32af03
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 1 deletion.
diff --git a/accessibility-checker-engine/src/v2/dom/DOMWalker.ts b/accessibility-checker-engine/src/v2/dom/DOMWalker.ts
@@ -289,7 +289,7 @@ export class DOMWalker {
                 }
             }
         } while (
-            (this.node.nodeType !== 1 /* Node.ELEMENT_NODE */ && this.node.nodeType !== 11)
+            (this.node.nodeType !== 1 /* Node.ELEMENT_NODE */ && this.node.nodeType !== 11 && this.node.nodeType !== 3 )
             || (this.node.nodeType === 1 && (this.node as Element).getAttribute("aChecker") === "ACE")
         );
         return true;

diff --git a/...r-engine/test/v2/checker/accessibility/rules/list_markup_review_ruleunit/dcs-example.html b/...r-engine/test/v2/checker/accessibility/rules/list_markup_review_ruleunit/dcs-example.html
@@ -0,0 +1,47 @@
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
+
+<!--
+   /******************************************************************************
+     Copyright:: 2020- IBM, Inc
+
+    Licensed under the Apache License, Version 2.0 (the "License");
+    you may not use this file except in compliance with the License.
+    You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+  *****************************************************************************/
+-->
+
+<html lang="en">
+
+<head>
+	<title>RPT Test Suite</title>
+</head>
+
+<body>
+  <main>
+    <div>
+        <p id="debug1">Create groups in <span class="ph">Turbonomic</span> so you can manage Database Servers with ease.
+            To create groups, go to <strong>Settings &gt; Groups</strong>, and then select <strong>New Group &gt; Database
+              Server</strong>. In the page that displays, choose <strong>Dynamic</strong> (recommended) and then set the
+            filter as follows:</p>
+    </div>
+  </main>
+
+<script type="text/javascript">
+  UnitTest = {
+            ruleIds: ["list_markup_review"],
+            results: [
+
+            ]
+        };
+//]]>
+</script></body>
+
+</html>