Merge pull request #1049 from IBMa/joho-tabstops-HardLaunch-Final

New Keyboard Visualization Feature for Checker
IBMa · Aug 23, 2022 · de54297 · de54297
2 parents 910c787 + 3a0fd95
commit de54297
Show file tree

Hide file tree

Showing 67 changed files with 4,811 additions and 2,652 deletions.
diff --git a/accessibility-checker-engine/src/genHelp.ts b/accessibility-checker-engine/src/genHelp.ts
@@ -79,6 +79,12 @@ const valueMap = {
         "Fail": "Recommendation",
         "Pass": "Pass",
         "Manual": "Recommendation"
+    },
+    "INFORMATION": {
+        "POTENTIAL": "Needs review",
+        "FAIL": "Violation",
+        "PASS": "Pass",
+        "MANUAL": "Recommendation"
     }
 };
 

diff --git a/accessibility-checker-engine/src/v4/rules/element_tabbable_visible.ts b/accessibility-checker-engine/src/v4/rules/element_tabbable_visible.ts
@@ -67,6 +67,7 @@ export let element_tabbable_visible: Rule = {
 
         let top = bounds['top'];
         let left = bounds['left'];     
+
         if (Object.keys(onfocus_styles).length === 0 ) {
             // no onfocus position change, but could be changed from js 
             return RulePotential("potential_visible", []);
@@ -91,7 +92,7 @@ export let element_tabbable_visible: Rule = {
             }    
         }
 
-        if (top > 0 && left > 0)
+        if (top >= 0 && left >= 0)
             return RulePass("pass");
         else
             return RulePotential("potential_visible", []);

diff --git a/accessibility-checker-extension/manifest_Chrome.json b/accessibility-checker-extension/manifest_Chrome.json
@@ -43,5 +43,11 @@
 		"page": "options.html",
 		"open_in_tab": true
     },
+	"content_scripts": [ 
+        {
+        "matches": ["<all_urls>"],
+        "js": ["draw.js"]
+        }
+    ], 
     "incognito": "split"
 }
diff --git a/accessibility-checker-extension/manifest_Firefox.json b/accessibility-checker-extension/manifest_Firefox.json
@@ -35,6 +35,12 @@
 		],
 		"persistent": true
 	},
+	"content_scripts": [ 
+        {
+        "matches": ["<all_urls>"],
+        "js": ["draw.js"]
+        }
+    ], 
 	"options_ui": {
 		"page": "options.html",
 		"open_in_tab": true

diff --git a/accessibility-checker-extension/package-lock.json b/accessibility-checker-extension/package-lock.json
diff --git a/accessibility-checker-extension/package.json b/accessibility-checker-extension/package.json
@@ -29,6 +29,7 @@
 		"react-tooltip": "^4.2.21",
 		"redux": "^4.1.2",
 		"string-hash": "^1.1.3",
+		"tabbable": "^5.2.0",
 		"webext-redux": "^2.1.9"
 	},
 	"devDependencies": {

diff --git a/accessibility-checker-extension/src/assets/element.svg b/accessibility-checker-extension/src/assets/element.svg
diff --git a/accessibility-checker-extension/src/assets/enter.svg b/accessibility-checker-extension/src/assets/enter.svg
diff --git a/accessibility-checker-extension/src/assets/esc.svg b/accessibility-checker-extension/src/assets/esc.svg
diff --git a/accessibility-checker-extension/src/assets/img/2_A11yIssues.png b/accessibility-checker-extension/src/assets/img/2_A11yIssues.png
diff --git a/accessibility-checker-extension/src/assets/img/3.1Checker1.png b/accessibility-checker-extension/src/assets/img/3.1Checker1.png
diff --git a/accessibility-checker-extension/src/assets/img/3.1Checker2.png b/accessibility-checker-extension/src/assets/img/3.1Checker2.png
diff --git a/accessibility-checker-extension/src/assets/img/3.1Checker3.png b/accessibility-checker-extension/src/assets/img/3.1Checker3.png
diff --git a/accessibility-checker-extension/src/assets/img/3.1Checker4.png b/accessibility-checker-extension/src/assets/img/3.1Checker4.png
diff --git a/accessibility-checker-extension/src/assets/img/3.2Report.png b/accessibility-checker-extension/src/assets/img/3.2Report.png
diff --git a/accessibility-checker-extension/src/assets/img/3.3Multi1.png b/accessibility-checker-extension/src/assets/img/3.3Multi1.png
diff --git a/accessibility-checker-extension/src/assets/img/3.3Multi2.png b/accessibility-checker-extension/src/assets/img/3.3Multi2.png
diff --git a/accessibility-checker-extension/src/assets/img/3.3Multi3.png b/accessibility-checker-extension/src/assets/img/3.3Multi3.png
diff --git a/accessibility-checker-extension/src/assets/img/3.3Multi4.png b/accessibility-checker-extension/src/assets/img/3.3Multi4.png
diff --git a/accessibility-checker-extension/src/assets/img/3.4Focus.png b/accessibility-checker-extension/src/assets/img/3.4Focus.png
diff --git a/accessibility-checker-extension/src/assets/img/3.5Keyboard1.png b/accessibility-checker-extension/src/assets/img/3.5Keyboard1.png
diff --git a/accessibility-checker-extension/src/assets/img/3.5Keyboard2.png b/accessibility-checker-extension/src/assets/img/3.5Keyboard2.png
diff --git a/accessibility-checker-extension/src/assets/img/3.5Keyboard3.png b/accessibility-checker-extension/src/assets/img/3.5Keyboard3.png
diff --git a/accessibility-checker-extension/src/assets/img/3.5Keyboard4.png b/accessibility-checker-extension/src/assets/img/3.5Keyboard4.png
diff --git a/accessibility-checker-extension/src/assets/img/3.5Keyboard5.png b/accessibility-checker-extension/src/assets/img/3.5Keyboard5.png
diff --git a/accessibility-checker-extension/src/assets/img/4_A11yAssess.png b/accessibility-checker-extension/src/assets/img/4_A11yAssess.png
diff --git a/accessibility-checker-extension/src/assets/img/4_A11yAssess2.png b/accessibility-checker-extension/src/assets/img/4_A11yAssess2.png
diff --git a/accessibility-checker-extension/src/assets/img/4_A11yAssess3.png b/accessibility-checker-extension/src/assets/img/4_A11yAssess3.png
diff --git a/accessibility-checker-extension/src/assets/img/5_Options.png b/accessibility-checker-extension/src/assets/img/5_Options.png
diff --git a/accessibility-checker-extension/src/assets/img/7.1Report.png b/accessibility-checker-extension/src/assets/img/7.1Report.png
diff --git a/accessibility-checker-extension/src/assets/img/keyboard-element.svg b/accessibility-checker-extension/src/assets/img/keyboard-element.svg
diff --git a/accessibility-checker-extension/src/assets/img/keyboard-issue.svg b/accessibility-checker-extension/src/assets/img/keyboard-issue.svg
diff --git a/accessibility-checker-extension/src/assets/keyboard disabled.svg b/accessibility-checker-extension/src/assets/keyboard disabled.svg
diff --git a/accessibility-checker-extension/src/assets/keyboard.svg b/accessibility-checker-extension/src/assets/keyboard.svg
diff --git a/accessibility-checker-extension/src/assets/keyboard_issue.svg b/accessibility-checker-extension/src/assets/keyboard_issue.svg
diff --git a/accessibility-checker-extension/src/assets/keyboard_white.svg b/accessibility-checker-extension/src/assets/keyboard_white.svg
diff --git a/accessibility-checker-extension/src/assets/left_right.svg b/accessibility-checker-extension/src/assets/left_right.svg
diff --git a/accessibility-checker-extension/src/assets/shift.svg b/accessibility-checker-extension/src/assets/shift.svg
diff --git a/accessibility-checker-extension/src/assets/space.svg b/accessibility-checker-extension/src/assets/space.svg
diff --git a/accessibility-checker-extension/src/assets/tab.svg b/accessibility-checker-extension/src/assets/tab.svg
diff --git a/accessibility-checker-extension/src/assets/tab_stop.svg b/accessibility-checker-extension/src/assets/tab_stop.svg