Patch: models store unique nodes #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: naweedkhan <[email protected]>
Signed-off-by: naweedkhan <[email protected]>
Signed-off-by: naweedkhan <[email protected]>
Signed-off-by: naweedkhan <[email protected]>
Signed-off-by: naweedkhan <[email protected]>
Signed-off-by: naweedkhan <[email protected]>
Signed-off-by: naweedkhan <[email protected]>
All leaf formulae have to be instantiated with a model.
e.g. `P = Predicate("P", model=m)`
connective formulae automatically inherit the model from one of the children. All formulae nodes are automatically attached to the model graph. The model enforces unique naming for nodes attached to its graph.
- rename connective_str -> syntax
- rename node_structure -> node_syntax
- fix numbering convention of the nodes attached to the model
- fixed naming of nodes to enforce a unique node per model - based on the model syntax.
Signed-off-by: naweedkhan <[email protected]>
Signed-off-by: naweedkhan <[email protected]>
Signed-off-by: naweedkhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a given node syntax, the model stores only one instance of that node.
API changes require leaf nodes to be instanciated with a model attached to it, with connective formulae inheriting the model from a child node.