Add travis test for DockerHub images #49
Conversation
Tomcli
changed the title
|
Thanks @Tomcli |
* Add a new Travis job to test DockerHub images and modify Travis to run 2 test jobs in parallel. * Move the test script commands under etc/travis. * Add new helper make function pull-dockerhub-images to pull the DockerHub images with tag 0.0.1-master.
Makefile
Outdated
| pull-dockerhub-images: $(addprefix pull-, $(TEST_IMAGES)) | ||
|
|
||
| $(addprefix pull-, $(TEST_IMAGES)): pull-%: % | ||
| @TRAVIS_IMAGES=$< make .pull-dockerhub-images |
There was a problem hiding this comment.
nitpick: perhaps better TRAVIS_IMAGE instead of TRAVIS_IMAGES? (also in lines 221, 226, 229)
Makefile
Outdated
| @@ -22,6 +22,10 @@ UI_REPO = [email protected]:IBM/FfDL-dashboard.git | |||
| CLI_CMD = $(shell pwd)/cli/bin/ffdl-$(UNAME_SHORT) | |||
| CLUSTER_NAME ?= mycluster | |||
| PUBLIC_IP ?= 127.0.0.1 | |||
| TRAVIS_IMAGES_VERSION ?= 0.0.1-master | |||
| TEST_IMAGES = $(addprefix $(DOCKER_NAMESPACE)/, $(TEST_IMAGES_SUBFIX)) | |||
There was a problem hiding this comment.
nitpick: I think "suffix" would be the more common terminology (TEST_IMAGES_SUFFIX)
| @@ -0,0 +1,11 @@ | |||
| # fail fast | |||
There was a problem hiding this comment.
Given how we're calling these scripts from .travis.yml, do we need to add shebangs at the top of these scripts?
#!/bin/bash
...
| export MAKE_ARGS=--no-print-directory | ||
| # pull images from dockerhub | ||
| make $MAKE_ARGS pull-dockerhub-images | ||
| make $MAKE_ARGS tag-dockerhub-images-to-latest |
There was a problem hiding this comment.
Looks like a good workaround solution for now, but I guess at some point we should make the Docker tags parameterizable in the deployment script, so we don't need to overwrite latest tag here (as Animesh mentioned).
|
Moved to #111 |
etc/travis.pull-dockerhub-imagesto pull the DockerHub images with tag0.0.1-master.