-
Notifications
You must be signed in to change notification settings - Fork 28
No grade bug fix #58
base: master
Are you sure you want to change the base?
No grade bug fix #58
Conversation
This reverts commit 3c64ba4feaf77d7171e0aa7eeed6b911f7e008ce.
.travis.yml
Outdated
@@ -5,7 +5,7 @@ deploy: | |||
provider: npm | |||
email: [email protected] | |||
api_key: | |||
secure: XfxcXQvUIlDRiPvKNxsoL3sOEALcDd9uY6FR6TQls3C8nR8+Ocq/WfLYhG53J5Tl0E8EsG/2a9HVTT0+k1RG9bDSthM8ztRm9Y/Fi4ZqN4Wn5BfepOUl24SPqwmG/48w/Wu/cn3wOFEu5h7Y3iiTkcyk5hwJr54THKMH7J313KU= | |||
secure: <needthis> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original secure key is correct! I need to get a new one for color-bee.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, my bad. Changed it back.
Also @cuyaproductions, does the Readme still reflect this or are there changes in calling the sass? |
@seejamescode, I just updated the color examples on the README file to match the current color values and added a small section about running tests. |
Quite a lot of commits in this PR. Not sure about your team but in my team we are told to squash them into 1 or whatever number that actually makes sense, with the ticket number preceding by |
I'd like to help reviewing this PR, but It's way too large with way too many changes to sanely review. Please break this PR up. The issue at hand only mentions not being able to pass just a color name to a Sass mixin, yet I see a whole new testing framework, changes to docs, color palettes, Gulpfile, and sketch files. That's way more code than needed. I'd recommend the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is too large to review effectively and resolves much more than just the issue it's attached to. Please review my comments from #58 (comment) and resubmit
Closes #53
NOTE: This is a rebased PR from my original PR for IBM-Design/color-bee. I tried to be as thorough with my rebase to make sure it matches this project's structure. But there is chance, I might have missed something.
Problem
The assumption is that if I use the color function without a grade argument, I should get the core grade of the color I am requesting:
The default value for the
$grade
parameter in thecolor()
function is set to0
which currently no color has this as a possible grade. Updating the default$grade
value to a number that does in fact exist in all palettes doesn't work because each color has a different core grade associated with it.Solution
The solution I have come up with is to add one more grade item to each color map in the output
_bee-palette.scss
with the key ofcore
and value of whatever that palette's core grade hex value is. This way we can set the default value for$grade
in thecolor()
function to'core'
and fulfill the expected behavior of calling thecolor()
function without supplying a grade.Along with this solutions, I took the liberty to:
.ase
,.json
, and.scl
output templates to include the core grade value.color()
function to throw an error if the user provides a color or grade that does not exist as well as a warning if they're outside of the$alpha
channel value range.color()
function using True and Mocha! Sadly, I don't think there is a way to test for errors which would have been nice.